Improve readability of json_lex()
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253069psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 22, 2026 at 12:10 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t253069_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t253069_1 && git checkout t253069_1Patchset v1 (message #1) is on t253069_1
I've been working in json_lex() for a little bit to add support for
JSONC[0]https://jsonc.org (patches to come later). In my endeavors to do so, I found
json_lex() to be quite beefy. Part of that is due to it being the entry
point for lexing when using both the incremental and non-incremental
JSON parsers. This leads to large sections of branching that seem to
hurt readability.
I've separated each refactor into its own commit such that we could take
some, all, or none of them. I know refactoring can be very opinionated.
Based on my experience with the upcoming JSONC patches, I have found
these changes to allow my future changes to be much more reviewable.
Ideally, these changes also make it easier for future readers to
understand and contribute in the JSON lexing code. History points to
this code being pretty static with the largest change coming when Andrew
added the non-recursive (incremental) parser.
Maybe others have thought of other ways to make this function a bit more
approachable.
[0]: https://jsonc.org
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)