[PATCH] Remove unused scram_client_key_len and scram_server_key_len fields

Started by Aleksander Alekseev19 days ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

This thread has been committed, so CI has stopped here. Anything below is the last result it produced.

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253322
psql -h localhost -U postgres

Built from patchset v1 (message #1), August 06, 2026 at 12:19 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t253322_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t253322_1 && git checkout t253322_1

Patchset v1 (message #1) is on t253322_1

Jump to latest
#1Aleksander Alekseev
aleksander@timescale.com

Hi,

I discovered some dead code in libpq. The proposed patch removes it.

--
Best regards,
Aleksander Alekseev

Attachments:

t253322_1
v1-0001-libpq-remove-unused-scram_client_key_len-and-scra.patchtext/x-patch; charset=US-ASCII; name=v1-0001-libpq-remove-unused-scram_client_key_len-and-scra.patchDownload+0-5
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Remove unused scram_client_key_len and scram_server_key_len fields

On 5 Aug 2026, at 14:03, Aleksander Alekseev <aleksander@tigerdata.com> wrote:

I discovered some dead code in libpq. The proposed patch removes it.

Seems reasonable. External code should also not reach into PGconn since it's
subject to change, and searching on Github/Debian codesearch doesn't turn up
any extension violating this. Will apply to master unless objections.

--
Daniel Gustafsson

#3Matheus Alcantara
matheusssilv97@gmail.com
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Remove unused scram_client_key_len and scram_server_key_len fields

On 05/08/26 09:03, Aleksander Alekseev wrote:

Hi,

I discovered some dead code in libpq. The proposed patch removes it.

Good finding. This is an oversight in 761c79508e7 which implemented
the scram pass-through feature.

The patch looks good to me.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Matheus Alcantara (#3)
Re: [PATCH] Remove unused scram_client_key_len and scram_server_key_len fields

On 6 Aug 2026, at 15:15, Matheus Alcantara <matheusssilv97@gmail.com> wrote:

On 05/08/26 09:03, Aleksander Alekseev wrote:

Hi,
I discovered some dead code in libpq. The proposed patch removes it.

Good finding. This is an oversight in 761c79508e7 which implemented the scram pass-through feature.

The patch looks good to me.

Pushed, thanks!

--
Daniel Gustafsson