Fix a typo in EnableLogicalDecoding()
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253641psql -h localhost -U postgresBuilt from patchset v5 (message #5), September 20, 2026 at 03:39 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t253641_5 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t253641_5 && git checkout t253641_5Patchset v5 (message #5) is on t253641_5
Hi,
I just noticed this typo while working on patch [1]/messages/by-id/BE0F3929-D0F7-4A59-A7B3-3D6972B813BD@gmail.com.
In the attached patch, I just changed “all process starts” to “all processes starting”, the formatting change was done by pgindent. The typo is an oversight in 67c20979c.
[1]: /messages/by-id/BE0F3929-D0F7-4A59-A7B3-3D6972B813BD@gmail.com
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
I just noticed this typo while working on patch [1].
Hi Chao,
Your fix looks good! I noticed three more typos in the same file and fixed them:
1. Changed "there in an" to "there is an"
2. Fixed "include ... to WAL records"
3. Fixed "the disabling logical decoding"
I’ve attached the updated file (v2) with all these changes included.
Thanks,
Shihao
Also, I realized there is no commit feast link for it. I created one
https://commitfest.postgresql.org/patch/7248/
On Tue, Sep 01, 2026 at 09:57:56PM -0400, shihao zhong wrote:
Also, I realized there is no commit feast link for it. I created one
https://commitfest.postgresql.org/patch/7248/
Sounds fine here, so grabbed it for later.
--
Michael
Hi Chao, Shihao, Michael,
Thank you for the patches, v2 patch looks good.
Attached v3 is v2 with the below one additional change, it applies on its
own.
There is one more spot, in UpdateLogicalDecodingStatusEndOfRecovery where I
felt the comment could be made more clear.
"* ... On the other hand, we need to wait for synchronizing
* XLogLogicalInfo even if we've not updated the status above as the
* status have been turned on and off during recovery, having running
* processes have different status on their local caches."
Updated the above in v3 as
"* ... On the other hand, we need to wait for XLogLogicalInfo to be
* synchronized even if we've not updated the status above, as the
* status may have been turned on and off during recovery, leaving
* running processes with different values in their local caches."
I'm not sure if this reword is worth the churn, happy to drop it if you'd
rather keep the original wording.
Regards,
Surya Poondla
I'm not sure if this reword is worth the churn, happy to drop it if you'd rather keep the original wording.
Hi Surya,
The revised wording is much clearer.
LGTM!
Thanks,
Shihao
Hi all,
On Thu, Sep 10, 2026 at 10:26 AM surya poondla <suryapoondla4@gmail.com> wrote:
Hi Chao, Shihao, Michael,
Thank you for the patches, v2 patch looks good.
Attached v3 is v2 with the below one additional change, it applies on its own.There is one more spot, in UpdateLogicalDecodingStatusEndOfRecovery where I felt the comment could be made more clear.
"* ... On the other hand, we need to wait for synchronizing
* XLogLogicalInfo even if we've not updated the status above as the
* status have been turned on and off during recovery, having running
* processes have different status on their local caches."Updated the above in v3 as
"* ... On the other hand, we need to wait for XLogLogicalInfo to be
* synchronized even if we've not updated the status above, as the
* status may have been turned on and off during recovery, leaving
* running processes with different values in their local caches."I'm not sure if this reword is worth the churn, happy to drop it if you'd rather keep the original wording.
Thank you for the updated patch. I reviewed the patch and went through
the changes in src/backend/replication/logical/logicalctl.c. I agree
with the corrections made so far. The additional typo fixes in v2
patch looks correct to me too, and also I agree with the revised
wording in UpdateLogicalDecodingStatusEndOfRecovery(), which seems
more clearer and easier to understand. The patch applies cleanly to my
tree, and I confirmed that the changes are limited to comments and do
not alter the code behavior.
Regards,
Solai