postgres_fdw: Fix crash when estimating joins with functions

Started by Fujii Masao2 months ago3 messageshackers
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

On master, I found that the following causes a segmentation fault:

CREATE EXTENSION postgres_fdw;
CREATE SERVER loopback FOREIGN DATA WRAPPER postgres_fdw;
CREATE USER MAPPING FOR PUBLIC SERVER loopback;
CREATE TABLE t (i int);
CREATE FOREIGN TABLE ft (i int) SERVER loopback
OPTIONS (table_name 't', use_remote_estimate 'true');
EXPLAIN SELECT * FROM generate_series(1, 3) g JOIN ft ON ft.i = g;

This crash seems to occur because init_func_stub_fpinfo() forgets to copy
the user mapping to the function-side stub, leaving it NULL. The NULL
mapping is then passed to GetConnection() when requesting a remote
estimate, causing the segmentation fault.

This seems to have been introduced by commit 0ee83dd4a99.

The attached patch fixes this by also copying the user mapping from the
foreign side.

Regards,

--
Fujii Masao

Attachments:

t253729_1
v1-0001-postgres_fdw-Fix-crash-when-estimating-joins-with.patchapplication/octet-stream; name=v1-0001-postgres_fdw-Fix-crash-when-estimating-joins-with.patchDownload+2-2
#2Alexander Pyhalov
a.pyhalov@postgrespro.ru
In reply to: Fujii Masao (#1)
Re: postgres_fdw: Fix crash when estimating joins with functions

Fujii Masao писал(а) 2026-09-09 17:02:

Hi,

On master, I found that the following causes a segmentation fault:

CREATE EXTENSION postgres_fdw;
CREATE SERVER loopback FOREIGN DATA WRAPPER postgres_fdw;
CREATE USER MAPPING FOR PUBLIC SERVER loopback;
CREATE TABLE t (i int);
CREATE FOREIGN TABLE ft (i int) SERVER loopback
OPTIONS (table_name 't', use_remote_estimate 'true');
EXPLAIN SELECT * FROM generate_series(1, 3) g JOIN ft ON ft.i = g;

This crash seems to occur because init_func_stub_fpinfo() forgets to
copy
the user mapping to the function-side stub, leaving it NULL. The NULL
mapping is then passed to GetConnection() when requesting a remote
estimate, causing the segmentation fault.

This seems to have been introduced by commit 0ee83dd4a99.

The attached patch fixes this by also copying the user mapping from the
foreign side.

Regards,

Hi. Thanks. Looks good to me.

--
Best regards,
Alexander Pyhalov,
Postgres Professional

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Alexander Pyhalov (#2)
Re: postgres_fdw: Fix crash when estimating joins with functions

On Thu, Sep 10, 2026 at 12:09 AM Alexander Pyhalov
<a.pyhalov@postgrespro.ru> wrote:

Hi. Thanks. Looks good to me.

Thanks for the review! I've pushed the patch.

Regards,

--
Fujii Masao