Commits
Fix misplaced comment in snapbuild.c.
masterunreleased
Committed by Masahiko SawadaSeptember 10, 2026 at 08:33 PM
Credits
AuthorAntonin Houska
CommitterMasahiko Sawada
CI
Applieswon't retry44d behind master
This thread has been committed, so CI has stopped here. Anything below is the last result it produced.
Buildsuccess2m 56s / 5m 42s
Tests1022 / 1022
GitHub runGitHub branchCI history
Participants
Masahiko Sawada
Masahiko Sawada
Antonin Houska
Antonin Houska
Attachments
Download Latest Patchset
+5-4
Show all attachments
Show all patchsets
Thread Outline
#1Antonin HouskaAntonin Houska
Sep 09, 18:35
#2Masahiko Sawada↳Masahiko Sawadato Antonin Houska (#1)
Sep 10, 20:06
#3Masahiko Sawada↳Masahiko Sawadato Masahiko Sawada (#2)
Sep 10, 20:34

Misplaced comment in snapbuild.c

Started by Antonin Houskaabout 2 months ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

This thread has been committed, so CI has stopped here. Anything below is the last result it produced.

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253731
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 10, 2026 at 06:49 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t253731_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t253731_1 && git checkout t253731_1

Patchset v1 (message #1) is on t253731_1

Jump to latest
#1Antonin Houska
Antonin Houska
ah@cybertec.at

This patch moves a comment to where it was until commits 2bef06d516 and
240e0dbacd added some code (including another comment) in front of the related
line.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com

Attachments:

t253731_1
move_comment_to_original_location.difftext/x-diffDownload+5-4
#2Masahiko Sawada
Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Antonin Houska (#1)
Re: Misplaced comment in snapbuild.c

Hi,

On Wed, Sep 9, 2026 at 11:36 AM Antonin Houska <ah@cybertec.at> wrote:

This patch moves a comment to where it was until commits 2bef06d516 and
240e0dbacd added some code (including another comment) in front of the related
line.

Thank you for the report and the patch. I agree to fix it. I'll push it shortly.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

#3Masahiko Sawada
Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Masahiko Sawada (#2)
Re: Misplaced comment in snapbuild.c

On Thu, Sep 10, 2026 at 1:06 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Hi,

On Wed, Sep 9, 2026 at 11:36 AM Antonin Houska <ah@cybertec.at> wrote:

This patch moves a comment to where it was until commits 2bef06d516 and
240e0dbacd added some code (including another comment) in front of the related
line.

Thank you for the report and the patch. I agree to fix it. I'll push it shortly.

Done.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

← Back to Topics