Fix primary status update WAL position description

Started by Fujii Masao5 days ago3 messagesdocs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

This thread has been committed, so CI has stopped here. Anything below is the last result it produced.

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253761
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 16, 2026 at 03:16 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t253761_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t253761_1 && git checkout t253761_1

Patchset v1 (message #1) is on t253761_1

Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

Commit 5f3a49abf7f changed the primary status update message to report the
end of the last inserted WAL record instead of the WAL write position.
But, the protocol docs still describes the WAL position field as
the latest WAL write position, which no longer matches the message sent by
walsender.

Attached patch updates the description of the WAL position field to
indicate the end of the
last inserted WAL record, matching the implementation.

Regards,

--
Fujii Masao

Attachments:

t253761_1
v1-0001-doc-Fix-primary-status-update-WAL-position-descri.patchapplication/octet-stream; name=v1-0001-doc-Fix-primary-status-update-WAL-position-descri.patchDownload+1-2
#2Ayush Tiwari
ayushtiwari.slg01@gmail.com
In reply to: Fujii Masao (#1)
Re: Fix primary status update WAL position description

Hi,

On Fri, 11 Sept 2026 at 08:06, Fujii Masao <masao.fujii@gmail.com> wrote:

Hi,

Commit 5f3a49abf7f changed the primary status update message to report the
end of the last inserted WAL record instead of the WAL write position.
But, the protocol docs still describes the WAL position field as
the latest WAL write position, which no longer matches the message sent by
walsender.

Attached patch updates the description of the WAL position field to
indicate the end of the
last inserted WAL record, matching the implementation.

Thanks for the patch.

Changes LGTM.

Regards,
Ayush

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Ayush Tiwari (#2)
Re: Fix primary status update WAL position description

On Fri, Sep 11, 2026 at 2:10 PM Ayush Tiwari
<ayushtiwari.slg01@gmail.com> wrote:

Changes LGTM.

Thanks for the review! I've pushed the patch.

Regards,

--
Fujii Masao