Typo in version check in postgresAcquireSampleRowsFunc
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
This thread has been committed, so CI has stopped here. Anything below is the last result it produced.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253967psql -h localhost -U postgresBuilt from patchset v1 (message #1), October 05, 2026 at 12:03 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t253967_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t253967_1 && git checkout t253967_1Patchset v1 (message #1) is on t253967_1
Hi,
While working on postgres_fdw stats import's open item, I noticed
$SUBJECT. Attached is a patch for fixing it.
Best regards,
Etsuro Fujita
On Sep 28, 2026, at 19:38, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
Hi,
While working on postgres_fdw stats import's open item, I noticed
$SUBJECT. Attached is a patch for fixing it.Best regards,
Etsuro Fujita
<fix-typo-in-version-check-in-AcquireSampleRowsFunc.patch>
LGTM. 90500 is for 9.5, there is 90600 for 9.6 also less than 95000.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On 28 Sep 2026, at 13:38, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on postgres_fdw stats import's open item, I noticed
$SUBJECT. Attached is a patch for fixing it.
Yikes. +1 on fixing, a quick round of grepping didn't find any other
instances.
--
Daniel Gustafsson
On Mon, Sep 28, 2026 at 8:49 PM Chao Li <li.evan.chao@gmail.com> wrote:
LGTM. 90500 is for 9.5, there is 90600 for 9.6 also less than 95000.
Yeah, this causes an unexpected error when the remote server is 9.5 or 9.6:
alter foreign table ft1 options (add analyze_sampling 'bernoulli');
analyze ft1;
ERROR: remote server does not support TABLESAMPLE feature
Will push. Thanks for looking!
Best regards,
Etsuro Fujita
On Tue, Sep 29, 2026 at 5:52 AM Daniel Gustafsson <daniel@yesql.se> wrote:
On 28 Sep 2026, at 13:38, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on postgres_fdw stats import's open item, I noticed
$SUBJECT. Attached is a patch for fixing it.Yikes. +1 on fixing, a quick round of grepping didn't find any other
instances.
Cool! Will push and backpatch. Thanks for looking!
Best regards,
Etsuro Fujita
On Wed, Sep 30, 2026 at 7:50 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
On Tue, Sep 29, 2026 at 5:52 AM Daniel Gustafsson <daniel@yesql.se> wrote:
On 28 Sep 2026, at 13:38, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on postgres_fdw stats import's open item, I noticed
$SUBJECT. Attached is a patch for fixing it.Yikes. +1 on fixing, a quick round of grepping didn't find any other
instances.Cool! Will push and backpatch.
Done. Thanks again, Daniel and Chao!
Best regards,
Etsuro Fujita