Comment typo in nodeWindowAgg.c

Started by Andreas Karlssonabout 15 years ago2 messages
#1Andreas Karlsson
andreas.karlsson@percona.com

Hi,

Found a couple of small typos in the comments of nodeWindowAgg.c when
they refer to functions in nodeAgg.c. The pluralities of the function
names (initialize_aggregates and advance_aggregates) are wrong. The
reference to "finalize_aggregate" is correct though.

diff --git a/src/backend/executor/nodeWindowAgg.c
b/src/backend/executor/nodeWindowAgg.c
index c3efe12..51f98c1 100644
*** a/src/backend/executor/nodeWindowAgg.c
--- b/src/backend/executor/nodeWindowAgg.c
*************** static bool window_gettupleslot(WindowOb
*** 181,187 ****
  /*
   * initialize_windowaggregate
!  * parallel to initialize_aggregate in nodeAgg.c
   */
  static void
  initialize_windowaggregate(WindowAggState *winstate,
--- 181,187 ----

/*
* initialize_windowaggregate
! * parallel to initialize_aggregates in nodeAgg.c
*/
static void
initialize_windowaggregate(WindowAggState *winstate,
*************** initialize_windowaggregate(WindowAggStat
*** 207,213 ****

  /*
   * advance_windowaggregate
!  * parallel to advance_aggregate in nodeAgg.c
   */
  static void
  advance_windowaggregate(WindowAggState *winstate,
--- 207,213 ----

/*
* advance_windowaggregate
! * parallel to advance_aggregates in nodeAgg.c
*/
static void
advance_windowaggregate(WindowAggState *winstate,

Regards,
Andreas Karlsson

#2Robert Haas
robertmhaas@gmail.com
In reply to: Andreas Karlsson (#1)
Re: Comment typo in nodeWindowAgg.c

On Tue, Dec 21, 2010 at 4:17 PM, Andreas Karlsson <andreas@proxel.se> wrote:

Found a couple of small typos in the comments of nodeWindowAgg.c when
they refer to functions in nodeAgg.c. The pluralities of the function
names (initialize_aggregates and advance_aggregates) are wrong. The
reference to "finalize_aggregate" is correct though.

Committed, thanks. But please attach patches rather than including them inline.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company