postmaster.pid also contains shared memory key
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
This thread has been committed, so CI has stopped here. Anything below is the last result it produced.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t254438psql -h localhost -U postgresBuilt from patchset v6 (message #6), November 02, 2026 at 12:34 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t254438_6 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t254438_6 && git checkout t254438_6Patchset v6 (message #6) is on t254438_6
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/storage-file-layout.html
Description:
On this page, postmaster.pid is said to contain "shared memory segment ID".
It would be better to say "shared memory segment key and ID". The second
last line has two numbers, which are the shared memory segment key (in
decimal instead of hex) and ID, respectively. This can be verified with
`ipcs -m'. If you only say "ID", readers may ask, Which one is the ID?
On Tue, Oct 27, 2026 at 08:56:24PM +0000, PG Doc comments form wrote:
On this page, postmaster.pid is said to contain "shared memory segment ID".
It would be better to say "shared memory segment key and ID". The second
last line has two numbers, which are the shared memory segment key (in
decimal instead of hex) and ID, respectively. This can be verified with
`ipcs -m'. If you only say "ID", readers may ask, Which one is the ID?
Would you like to write a patch?
--
Michael
Hi Michael,
The proposed change is too trivial. I just want to inform the documentation team. Most readers won't care anyway. Thank you!
Yong Huang
On Friday, October 30, 2026 at 07:21:41 PM CDT, Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Oct 27, 2026 at 08:56:24PM +0000, PG Doc comments form wrote:
On this page, postmaster.pid is said to contain "shared memory segment ID".
It would be better to say "shared memory segment key and ID". The second
last line has two numbers, which are the shared memory segment key (in
decimal instead of hex) and ID, respectively. This can be verified with
`ipcs -m'. If you only say "ID", readers may ask, Which one is the ID?
Would you like to write a patch?
--
Michael
On Sun, 2026-11-01 at 01:56 +0000, Yong Huang wrote:
On Friday, October 30, 2026 at 07:21:41 PM CDT, Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Oct 27, 2026 at 08:56:24PM +0000, PG Doc comments form wrote:
On this page, postmaster.pid is said to contain "shared memory segment ID".
It would be better to say "shared memory segment key and ID". The second
last line has two numbers, which are the shared memory segment key (in
decimal instead of hex) and ID, respectively. This can be verified with
`ipcs -m'. If you only say "ID", readers may ask, Which one is the ID?Would you like to write a patch?
The proposed change is too trivial. I just want to inform the documentation team.
Most readers won't care anyway. Thank you!
Nothing is too trivial. I do care - here is a patch.
Yours,
Laurenz Albe
On 1 Nov 2026, at 13:44, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
On Sun, 2026-11-01 at 01:56 +0000, Yong Huang wrote:
On Friday, October 30, 2026 at 07:21:41 PM CDT, Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Oct 27, 2026 at 08:56:24PM +0000, PG Doc comments form wrote:
On this page, postmaster.pid is said to contain "shared memory segment ID".
It would be better to say "shared memory segment key and ID". The second
last line has two numbers, which are the shared memory segment key (in
decimal instead of hex) and ID, respectively. This can be verified with
`ipcs -m'. If you only say "ID", readers may ask, Which one is the ID?Would you like to write a patch?
The proposed change is too trivial. I just want to inform the documentation team.
Most readers won't care anyway. Thank you!Nothing is too trivial. I do care - here is a patch.
Pushed, thanks.
--
Daniel Gustafsson
On Mon, Nov 2, 2026 at 4:16 AM Daniel Gustafsson <daniel@yesql.se> wrote:
Pushed, thanks.
Thanks for working on this!
I think it's better to also clarify the postmaster status and note that
the shared memory field is empty on Windows. Attached is a follow-up
patch documenting both and adding the segment ID to the pidfile.h comment.
Thought?
Regards,
--
Fujii Masao
On Mon, 2026-11-02 at 09:21 +0900, Fujii Masao wrote:
On Mon, Nov 2, 2026 at 4:16 AM Daniel Gustafsson <daniel@yesql.se> wrote:
Pushed, thanks.
Thanks for working on this!
I think it's better to also clarify the postmaster status and note that
the shared memory field is empty on Windows. Attached is a follow-up
patch documenting both and adding the segment ID to the pidfile.h comment.
Thought?
I think that your patch is a clear improvement.
Yours,
Laurenz Albe