pgsql: Deparse FOR PORTION OF using the range column's current name.

Started by Tom Lane4 months ago1 messagescommitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Deparse FOR PORTION OF using the range column's current name.

Commit 8e72d914c recorded the range column's name in ForPortionOfExpr
and used that for deparsing FOR PORTION OF. This gives the wrong
answer if the ForPortionOfExpr is saved in a rule or SQL function and
then the column gets renamed. Drop the ForPortionOfExpr.range_name
field; instead fetch the current column name from the catalogs when
needed.

Also drop ForPortionOfState.fp_rangeName, which wasn't being used
anywhere.

Full disclosure: an earlier draft of this patch was made with
Claude Opus 4.8.

Reported-by: John Naylor <johncnaylorls@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: /messages/by-id/CANWCAZYFEpJ5Oi45gi4q9Y6LYa4_oiAXxuNNWe-1ym-i0fF8Pw@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7090c696cc9ea96a278e679e8bbfe9b051740105

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 2 --
src/backend/optimizer/plan/planner.c | 4 +++-
src/backend/parser/analyze.c | 1 -
src/backend/utils/adt/ruleutils.c | 15 +++++++++----
src/include/catalog/catversion.h | 2 +-
src/include/nodes/execnodes.h | 1 -
src/include/nodes/primnodes.h | 1 -
src/test/regress/expected/for_portion_of.out | 33 ++++++++++++++++++++++++++++
src/test/regress/sql/for_portion_of.sql | 16 ++++++++++++++
9 files changed, 64 insertions(+), 11 deletions(-)