pgsql: pgcrypto: remove unused field mdc_checked from PGP_Context

Started by Daniel Gustafsson3 months ago1 messagescommitters
Jump to latest
#1Daniel Gustafsson
dgustafsson@postgresql.org

pgcrypto: remove unused field mdc_checked from PGP_Context

mdc_finish used to set this field once it had successfully verified
the MDC packet, with its only reader in the same function. This was
removed by a59ee881978 when mdc_finish stopped being called through
the pullf_read API, the field has been unused since.

Note that MDC verification does not rely on it: process_data_packets
tracks whether an MDC packet was seen in its local got_mdc variable
and rejects the message if a required MDC is missing, while the
use_mdcbuf_filter path checks the hash in mdcbuf_finish().

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Discussion: /messages/by-id/CAJ7c6TNmHnnCkn3uZwRUE7WWYftW--48JFoDVDqoZqMrLYxUZw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e8a8ccc3ca192178fd3a179a06a91368008899dc

Modified Files
--------------
contrib/pgcrypto/pgp-decrypt.c | 1 -
contrib/pgcrypto/pgp.h | 1 -
2 files changed, 2 deletions(-)