OCLASS_FOREIGN_TABLE support is incomplete
While poking at the extensions patch I noticed that doDeletion() and
getObjectDescription() both seem to be missing cases for
OCLASS_FOREIGN_TABLE. Surely this is broken.
regards, tom lane
On Fri, Feb 4, 2011 at 2:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
While poking at the extensions patch I noticed that doDeletion() and
getObjectDescription() both seem to be missing cases for
OCLASS_FOREIGN_TABLE. Surely this is broken.
I'll look into fixing this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Feb 4, 2011 at 2:46 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Feb 4, 2011 at 2:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
While poking at the extensions patch I noticed that doDeletion() and
getObjectDescription() both seem to be missing cases for
OCLASS_FOREIGN_TABLE. Surely this is broken.I'll look into fixing this.
Err... wait. Actually, I think the right thing to do might be to
remove OCLASS_FOREIGN_TABLE altogether. I don't think it's actually
used for anything. For a foreign table, we use OCLASS_CLASS, just as
we do for indexes and sequences. I think that's just leftover crap
that I failed to rip out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Robert Haas <robertmhaas@gmail.com> writes:
Err... wait. Actually, I think the right thing to do might be to
remove OCLASS_FOREIGN_TABLE altogether. I don't think it's actually
used for anything. For a foreign table, we use OCLASS_CLASS, just as
we do for indexes and sequences. I think that's just leftover crap
that I failed to rip out.
OK. I'll fix it as part of the extensions patch, since it's touching
all those same places anyway.
regards, tom lane
On Sat, Feb 5, 2011 at 10:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <robertmhaas@gmail.com> writes:
Err... wait. Actually, I think the right thing to do might be to
remove OCLASS_FOREIGN_TABLE altogether. I don't think it's actually
used for anything. For a foreign table, we use OCLASS_CLASS, just as
we do for indexes and sequences. I think that's just leftover crap
that I failed to rip out.OK. I'll fix it as part of the extensions patch, since it's touching
all those same places anyway.
Excellent, thanks!
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company