pgsql: libpq: Revert the connection option "servicefile"

Started by Michael Paquierabout 1 month ago4 messagescommitters
Jump to latest
#1Michael Paquier
michael@paquier.xyz

libpq: Revert the connection option "servicefile"

The following commits are reverted:
* 092f3c63efc6, libpq: Add "servicefile" connection option
* 6b1c4d326b06, psql: Add variable SERVICEFILE
* 90354030b8fc, libpq: Fix "servicefile" after fallback to system
service file

After more review, PGSERVICEFILE is sufficient for the purpose of
specifying a per-session service file. Some details around this feature
will need more attention before being actually usable, if we ever get
down to it.

One independent piece that has been committed during the v19 development
cycle is df286a5b830a, which is kept in the tree as that was an
unrelated change.

Reported-by: Sehrope Sarkuni <sehrope@jackdb.com>
Discussion: /messages/by-id/CAH7T-aq+U6GDPO8mr3Gga3KzxGpAE=BSLb38x+R8fvWjzF-H8w@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cbe71bac54ea2cdd0d352a91bda85746bf32ef72

Modified Files
--------------
doc/src/sgml/libpq.sgml | 24 +++-------
doc/src/sgml/ref/psql-ref.sgml | 9 ----
src/bin/psql/command.c | 7 ---
src/interfaces/libpq/fe-connect.c | 66 ++-------------------------
src/interfaces/libpq/libpq-int.h | 2 -
src/interfaces/libpq/t/006_service.pl | 86 +----------------------------------
6 files changed, 13 insertions(+), 181 deletions(-)

#2Bruce Momjian
bruce@momjian.us
In reply to: Michael Paquier (#1)
Re: pgsql: libpq: Revert the connection option "servicefile"

On Sun, Oct 18, 2026 at 10:35:21PM +0000, Michael Paquier wrote:

libpq: Revert the connection option "servicefile"

The following commits are reverted:
* 092f3c63efc6, libpq: Add "servicefile" connection option
* 6b1c4d326b06, psql: Add variable SERVICEFILE
* 90354030b8fc, libpq: Fix "servicefile" after fallback to system
service file

After more review, PGSERVICEFILE is sufficient for the purpose of
specifying a per-session service file. Some details around this feature
will need more attention before being actually usable, if we ever get
down to it.

One independent piece that has been committed during the v19 development
cycle is df286a5b830a, which is kept in the tree as that was an
unrelated change.

Reported-by: Sehrope Sarkuni <sehrope@jackdb.com>
Discussion: /messages/by-id/CAH7T-aq+U6GDPO8mr3Gga3KzxGpAE=BSLb38x+R8fvWjzF-H8w@mail.gmail.com
Backpatch-through: 19

I am getting these errors in the PG 19 doc build:

$ make check
/usr/bin/xmllint --nonet --path . --path . --noout --valid postgres.sgml
postgres.sgml:2252: element link: validity error : IDREF attribute linkend references an unknown ID "libpq-connect-servicefile"
postgres.sgml:2411: element link: validity error : IDREF attribute linkend references an unknown ID "app-psql-variables-servicefile"
make: *** [Makefile:204: check] Error 4

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

#3Michael Paquier
michael@paquier.xyz
In reply to: Bruce Momjian (#2)
Re: pgsql: libpq: Revert the connection option "servicefile"

On Sun, Oct 18, 2026 at 07:30:02PM -0400, Bruce Momjian wrote:

I am getting these errors in the PG 19 doc build:

Sorry about that, I have fat-fingered the backpatch for v19 in the
docs. This is now fixed with b46018985815.
--
Michael

#4Bruce Momjian
bruce@momjian.us
In reply to: Michael Paquier (#3)
Re: pgsql: libpq: Revert the connection option "servicefile"

On Mon, Oct 19, 2026 at 08:34:42AM +0900, Michael Paquier wrote:

On Sun, Oct 18, 2026 at 07:30:02PM -0400, Bruce Momjian wrote:

I am getting these errors in the PG 19 doc build:

Sorry about that, I have fat-fingered the backpatch for v19 in the
docs. This is now fixed with b46018985815.

Confirmed fixed, thanks.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.