pgsql: Fix argument handling in pg_indexam_progress_phasename()

Started by Michael Paquierabout 1 month ago1 messagescommitters
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Fix argument handling in pg_indexam_progress_phasename()

The function is declared in pg_proc.dat a bigint as its second input
argument, but the function's code used PG_GETARG_INT32().

This is an issue in 32-bit architectures in stable branches (up to v18)
where bigint is still passed by reference, reporting bogus numbers.
Since 2a600a93c7b (v19 and HEAD), this is less of a problem as Datums
became 8-byte wide everywhere.

Oversight in ab0dfc961b6.

Author: Markos Fountoulakis <markos@planetscale.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: /messages/by-id/e791bbb7-af3a-4a91-a5bb-c744e5c3ef54@planetscale.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5259332a691c5864db81c35a93629f61974a1c34

Modified Files
--------------
src/backend/utils/adt/amutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)