pgsql: Adjust pg_upgrade error message, array freeing, and add error ch

Started by Bruce Momjianabout 15 years ago4 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Adjust pg_upgrade error message, array freeing, and add error check.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fe8f15d5d2f42ad1ce6a0114c12fd3da0f14dd4a

Modified Files
--------------
contrib/pg_upgrade/check.c | 2 --
contrib/pg_upgrade/info.c | 9 +++++++++
contrib/pg_upgrade/pg_upgrade.c | 1 -
contrib/pg_upgrade/relfilenode.c | 2 +-
4 files changed, 10 insertions(+), 4 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch

Bruce Momjian <bruce@momjian.us> writes:

Adjust pg_upgrade error message, array freeing, and add error check.

The buildfarm says this patch is broken.

regards, tom lane

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#2)
Re: [COMMITTERS] pgsql: Adjust pg_upgrade error message, array freeing, and add error ch

Excerpts from Tom Lane's message of mar feb 15 18:05:59 -0300 2011:

Bruce Momjian <bruce@momjian.us> writes:

Adjust pg_upgrade error message, array freeing, and add error check.

The buildfarm says this patch is broken.

I have just pushed a fix for this. It's probably not the prettiest
thing in the world, but there doesn't seem to be a place where the
ClusterInfo structs are initialized. Maybe that merits more cleanup,
not sure.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#4Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

Adjust pg_upgrade error message, array freeing, and add error check.

The buildfarm says this patch is broken.

Thanks, fixed a few hours ago.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +