pgsql: Fix pgoutput crash on missing option values
Fix pgoutput crash on missing option values
The replication protocol allows options without values, but pgoutput
dereferenced a NULL DefElem argument for parameters proto_version and
publication_names. A replication client was able to crash a WAL sender.
This issue is fixed by reading both options with defGetString(), which
is able to report a missing parameter cleanly.
Reported-by: Brar Piening <brar@gmx.de>
Author: Zhijie Hou <houzhijie22@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: /messages/by-id/19795-6d7d506133b7f062@postgresql.org
Backpatch-through: 14
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c3ef3f2283d6a9b8d63ba35c5bc5ad4f1864682d
Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 10 ++++----
src/bin/pg_basebackup/t/030_pg_recvlogical.pl | 35 +++++++++++++++++++++++++++
2 files changed, 40 insertions(+), 5 deletions(-)