pgsql: Cleanup ClusterInfo initialization in pg_upgrade

Started by Alvaro Herreraabout 15 years ago2 messageshackers
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Cleanup ClusterInfo initialization in pg_upgrade

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b4a7e5980b2919d4d2a849d046a8e3a77e06fdb7

Modified Files
--------------
contrib/pg_upgrade/info.c | 6 ++++++
contrib/pg_upgrade/pg_upgrade.c | 5 +++--
contrib/pg_upgrade/pg_upgrade.h | 1 +
3 files changed, 10 insertions(+), 2 deletions(-)

#2Bruce Momjian
bruce@momjian.us
In reply to: Alvaro Herrera (#1)
Re: [COMMITTERS] pgsql: Cleanup ClusterInfo initialization in pg_upgrade

Alvaro Herrera wrote:

Cleanup ClusterInfo initialization in pg_upgrade

Global structs are already initialized to zero, so no need to initialize
them. I discussed this with Alvaro, and he suggested that there is no
need to free memory before we exit. The attached, applied patch makes
both changes.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachments:

/rtmp/difftext/x-diffDownload+20-33