pgsql: Remove unused tuple expansion and copying functions

Started by Andres Freund8 days ago1 messagescommitters
Jump to latest
#1Andres Freund
andres@anarazel.de

Remove unused tuple expansion and copying functions

minimal_expand_tuple() has been unused since 4da597edf1b and
heap_expand_tuple() since 20d3fe9009d, which in turn left the static
expand_tuple() unreachable. heap_copytuple_with_tuple() has had no
callers since 141fd1b66ce. Remove them.

Two regression test comments naming expand_tuple() are updated to
refer to the code that handles missing attributes nowadays.

Reported-by: Andres Freund <andres@anarazel.de>
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Kyle Snavely <kjsnavely@gmail.com>
Discussion: /messages/by-id/gf6hokynqjp6g7o4zh6yy7ekbdbig5cnnd6ilk6iw3aodilj43@5x7xrz52jhve

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/81b2179b492e3af891544813b7e22a42386b34d0

Modified Files
--------------
src/backend/access/common/heaptuple.c | 290 -----------------------------
src/include/access/htup_details.h | 3 -
src/test/regress/expected/fast_default.out | 4 +-
src/test/regress/sql/fast_default.sql | 4 +-
4 files changed, 4 insertions(+), 297 deletions(-)