pgsql: Fix formatting of to_char's EEEE output for numeric and bigint.

Started by Tom Lane4 days ago1 messagescommitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Fix formatting of to_char's EEEE output for numeric and bigint.

The integer and float code paths for EEEE format always produce a
single digit before the decimal point. However, the numeric code
path (shared by bigint) was careless about rounding: if rounding
increased the value from, say, 9.999 to 10.00, it got printed
that way. Fix that. Given the precedent of the other code paths,
this seems incontestably a bug, so back-patch.

While at it, provide some actual documentation about what this
format code is supposed to do, rather than leaving it to the
reader's imagination.

Author: Jianqiao Han <hanjianqiao@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: /messages/by-id/CAPOa_Zkc1QROJwB_JcB+f=6s1bUPRh7qr_H_=B_S-KZPa0V1DA@mail.gmail.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a355dde4df2b6360bbe1292c22061e948d9d0ee0

Modified Files
--------------
doc/src/sgml/func.sgml | 12 +++++++++---
src/backend/utils/adt/numeric.c | 16 ++++++++++++++++
src/test/regress/expected/numeric.out | 24 ++++++++++++++++++++++++
src/test/regress/sql/numeric.sql | 13 +++++++++++++
4 files changed, 62 insertions(+), 3 deletions(-)