pgsql: Pin relations in phase 1 of REINDEX CONCURRENTLY

Started by Michael Paquier2 days ago1 messagescommitters
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Pin relations in phase 1 of REINDEX CONCURRENTLY

Phase 1 of ReindexRelationConcurrently() evaluates index expressions and
predicates when computing the safety of each index and when creating the
definition of each new index. These may call functions run as the table
owner.

The old and new indexes processed in the previous iterations of the loop
were closed at this stage. Hence, a function was able to drop one of
them or reindex one of the new indexes, leading to an assertion failure
in the build phase, or to an internal error with a dropped index
committed.

The relations opened in phase 1 are now kept opened until the session
locks are taken, so as DDLs on them are blocked by CheckTableNotInUse().
The build and validation phases already pin the relations, and the
protections in build phase limit the damage to an ERROR.

Author: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Reviewed-by: Shihao Zhong <zhong950419@gmail.com>
Discussion: /messages/by-id/aver6A1EQEd2FaKq@paquier.xyz
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e5b33ff4514c6b7da8d7b8cbb6e157fba302e432

Modified Files
--------------
src/backend/commands/indexcmds.c | 28 ++++++++++++++++++----
src/test/regress/expected/create_index.out | 37 +++++++++++++++++++++++++++++-
src/test/regress/sql/create_index.sql | 26 ++++++++++++++++++++-
3 files changed, 84 insertions(+), 7 deletions(-)