pgsql: doc: Fix description of relative extension "directory" setting

Started by Daniel Gustafsson1 day ago1 messagescommitters
Jump to latest
#1Daniel Gustafsson
dgustafsson@postgresql.org

doc: Fix description of relative extension "directory" setting

Commit 81eaaa2c4 changed the documentation of the 'directory' control
file parameter to say that a relative path is resolved against the
directory where the control file was found. That is not what the code
does: a relative path is resolved against the base directory, i.e.,
the parent of the 'extension' directory in which the primary control
file was found (SHAREDIR or the corresponding extension_control_path
element). This is what the test_extensions TAP test expects, and it
keeps the long-standing convention of "directory = 'extension/foo'"
(with MODULEDIR) working.

Restore the pre-18 wording, extended to cover extension_control_path,
and mention in the description of extension_control_path that the
'directory' setting can cause script files to be loaded from somewhere
other than the control file's directory.

Backpatch to 18, where the incorrect wording was introduced.

Author: Mahendrakar Srinivasarao <mahendrakarforpg@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Discussion: /messages/by-id/CABkiuWpGiLzDg4D8zRBJ6DHnwYgHqkFxz2gDstXgeOdzh6bdZQ@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3802b59db1ff94fd57d4ba1422889432d15f085d

Modified Files
--------------
doc/src/sgml/config.sgml | 4 +++-
doc/src/sgml/extend.sgml | 9 ++++++---
2 files changed, 9 insertions(+), 4 deletions(-)