alpha5

Started by Robert Haasalmost 15 years ago17 messages
#1Robert Haas
robertmhaas@gmail.com

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

This time, I'm going to try to make sure that announcements actually
go out; I dropped the ball on that last time.

If anyone wants to push time zone updates, translation updates, etc.,
I suppose now's the time.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#2Robert Haas
robertmhaas@gmail.com
In reply to: Robert Haas (#1)
Re: alpha5

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken. Apparently we
don't have any automated testing of this? Anyone know what to fix
here?

openjade:tempfile_HISTORY.sgml:674:55:X: reference to non-existent ID
"GUC-DEADLOCK-TIMEOUT"
openjade:tempfile_HISTORY.sgml:677:23:X: reference to non-existent ID
"GUC-LOG-MIN-DURATION-STATEMENT"
openjade:tempfile_HISTORY.sgml:678:23:X: reference to non-existent ID
"GUC-LOG-AUTOVACUUM-MIN-DURATION"
openjade:tempfile_HISTORY.sgml:1116:23:X: reference to non-existent ID
"SQL-ALTERTABLE"
openjade:tempfile_HISTORY.sgml:676:23:X: reference to non-existent ID
"GUC-MAX-STANDBY-STREAMING-DELAY"
openjade:tempfile_HISTORY.sgml:675:23:X: reference to non-existent ID
"GUC-MAX-STANDBY-ARCHIVE-DELAY"

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#2)
Re: alpha5

Robert Haas <robertmhaas@gmail.com> writes:

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken. Apparently we
don't have any automated testing of this? Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

regards, tom lane

#4Alvaro Herrera
alvherre@commandprompt.com
In reply to: Tom Lane (#3)
Re: alpha5

Excerpts from Tom Lane's message of lun mar 28 10:26:59 -0300 2011:

Robert Haas <robertmhaas@gmail.com> writes:

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken. Apparently we
don't have any automated testing of this? Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

The long explanation is that history.sgml is used to generate HISTORY in
plain text, and for that it must be built standalone. So all references
to nodes external to that file are verboten.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#5Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#3)
Re: alpha5

On Mon, Mar 28, 2011 at 9:26 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken.  Apparently we
don't have any automated testing of this?  Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used <link> rather than <xref> for the things I used <xref>
for.

This is the sort of thing for which make maintainer-check would be very useful.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tom Lane (#3)
Re: alpha5

I wrote:

Robert Haas <robertmhaas@gmail.com> writes:

It seems that the 'make distcheck' build is broken. Apparently we
don't have any automated testing of this? Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

Quick hack applied. I think there's a better way, but I don't remember
it at this time of day.

regards, tom lane

#7Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#6)
Re: alpha5

On Mon, Mar 28, 2011 at 9:36 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

I wrote:

Robert Haas <robertmhaas@gmail.com> writes:

It seems that the 'make distcheck' build is broken.  Apparently we
don't have any automated testing of this?  Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

Quick hack applied.  I think there's a better way, but I don't remember
it at this time of day.

Slightly better hack applied.

Tarballs now at:

http://developer.postgresql.org/~rhaas/

Please sanity check and let me know if it looks OK to push these out for real.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#8Andrew Dunstan
andrew@dunslane.net
In reply to: Robert Haas (#2)
Re: alpha5

On 03/28/2011 09:25 AM, Robert Haas wrote:

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas<robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken. Apparently we
don't have any automated testing of this? Anyone know what to fix
here?

There is a bunch of things we don't test in a way that shows up
obviously, if at all. I'm thinking of making a buildfarm enhancement
that will allow performance of optional steps with some extra timing and
branch params. Obvious candidates include building the docs, looking for
typedefs, and benchmark runs as per Greg's post yesterday. The extra
config would look something like:

optional_steps => {
find_typedefs => { branches => ['HEAD'], min_hours_since => 23 },
benchmark => {dow => [0,2], min_hour => 3, max_hour => 6 },
build_docs => {min_hours_since => 72},
},

Adding a docs build to the buildfarm would at least show up errors like
the one you found pretty quickly. It's going to have to be optional,
though, as by no means does everyone have the required toolset installed.

cheers

andrew

#9Peter Eisentraut
peter_e@gmx.net
In reply to: Robert Haas (#5)
Re: alpha5

On mån, 2011-03-28 at 09:35 -0400, Robert Haas wrote:

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used <link> rather than <xref> for the things I used <xref>
for.

This is the sort of thing for which make maintainer-check would be
very useful.

And/or we could add the creation of these files to "make doc" or "make
world" or something.

#10Alvaro Herrera
alvherre@commandprompt.com
In reply to: Peter Eisentraut (#9)
Re: alpha5

Excerpts from Peter Eisentraut's message of lun mar 28 17:00:01 -0300 2011:

On mån, 2011-03-28 at 09:35 -0400, Robert Haas wrote:

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used <link> rather than <xref> for the things I used <xref>
for.

This is the sort of thing for which make maintainer-check would be
very useful.

And/or we could add the creation of these files to "make doc" or "make
world" or something.

I suggest having them be created in doc/src/sgml "all" target. This
gets them in "make docs" and "make world" AFAICT.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#11Alvaro Herrera
alvherre@commandprompt.com
In reply to: Alvaro Herrera (#10)
1 attachment(s)
Re: alpha5

Excerpts from Alvaro Herrera's message of sáb abr 09 01:55:45 -0300 2011:

Excerpts from Peter Eisentraut's message of lun mar 28 17:00:01 -0300 2011:

On mån, 2011-03-28 at 09:35 -0400, Robert Haas wrote:

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used <link> rather than <xref> for the things I used <xref>
for.

This is the sort of thing for which make maintainer-check would be
very useful.

And/or we could add the creation of these files to "make doc" or "make
world" or something.

I suggest having them be created in doc/src/sgml "all" target. This
gets them in "make docs" and "make world" AFAICT.

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachments:

0001-Generate-HISTORY-and-INSTALL-in-the-toplevel-Makefil.patchapplication/octet-stream; name=0001-Generate-HISTORY-and-INSTALL-in-the-toplevel-Makefil.patchDownload
From 78cbb21a99a48e102259c239cab0abebc41811b8 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Tue, 26 Apr 2011 11:33:54 -0300
Subject: [PATCH] Generate HISTORY and INSTALL in the toplevel Makefile's "make docs"

---
 doc/src/sgml/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
index c5078a8..65274dc 100644
--- a/doc/src/sgml/Makefile
+++ b/doc/src/sgml/Makefile
@@ -22,7 +22,7 @@ top_builddir = ../../..
 include $(top_builddir)/src/Makefile.global
 
 
-all: html man
+all: html man HISTORY INSTALL
 
 distprep: html distprep-man
 
-- 
1.7.4.1

#12Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Alvaro Herrera (#11)
Re: alpha5

On 26.04.2011 17:36, Alvaro Herrera wrote:

Excerpts from Alvaro Herrera's message of s�b abr 09 01:55:45 -0300 2011:

Excerpts from Peter Eisentraut's message of lun mar 28 17:00:01 -0300 2011:

On m�n, 2011-03-28 at 09:35 -0400, Robert Haas wrote:

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used<link> rather than<xref> for the things I used<xref>
for.

This is the sort of thing for which make maintainer-check would be
very useful.

And/or we could add the creation of these files to "make doc" or "make
world" or something.

I suggest having them be created in doc/src/sgml "all" target. This
gets them in "make docs" and "make world" AFAICT.

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

Does it need Internet connection?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

#13Alvaro Herrera
alvherre@commandprompt.com
In reply to: Heikki Linnakangas (#12)
Re: alpha5

Excerpts from Heikki Linnakangas's message of mié abr 27 07:47:32 -0300 2011:

On 26.04.2011 17:36, Alvaro Herrera wrote:

I suggest having them be created in doc/src/sgml "all" target. This
gets them in "make docs" and "make world" AFAICT.

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

Does it need Internet connection?

No, it only dumps the local HTML file into plain text.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#14Peter Eisentraut
peter_e@gmx.net
In reply to: Alvaro Herrera (#11)
Re: alpha5

On tis, 2011-04-26 at 11:36 -0300, Alvaro Herrera wrote:

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

Well, that will probably not be acceptable.

I rather think the action item here is to set up a buildfarm-ish job
that runs make distcheck, which is designed to, well, check if the
dist-making works.

#15Andrew Dunstan
andrew@dunslane.net
In reply to: Peter Eisentraut (#14)
Re: alpha5

On 04/27/2011 02:40 PM, Peter Eisentraut wrote:

On tis, 2011-04-26 at 11:36 -0300, Alvaro Herrera wrote:

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

Well, that will probably not be acceptable.

I rather think the action item here is to set up a buildfarm-ish job
that runs make distcheck, which is designed to, well, check if the
dist-making works.

I have just added some infrastructure support to the buildfarm for
adding optional steps. This one would be *really* easy to add.

cheers

andrew

#16Alvaro Herrera
alvherre@commandprompt.com
In reply to: Peter Eisentraut (#14)
Re: alpha5

Excerpts from Peter Eisentraut's message of mié abr 27 15:40:22 -0300 2011:

On tis, 2011-04-26 at 11:36 -0300, Alvaro Herrera wrote:

This is a trivial patch (attached). The only problem with it is that
"make all" would fail if lynx is not installed.

Well, that will probably not be acceptable.

Agreed.

I rather think the action item here is to set up a buildfarm-ish job
that runs make distcheck, which is designed to, well, check if the
dist-making works.

Makes sense.

(I wonder why don't we also install the HTML version of those files?)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#17Bruce Momjian
bruce@momjian.us
In reply to: Robert Haas (#5)
Re: alpha5

Robert Haas wrote:

On Mon, Mar 28, 2011 at 9:26 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Sat, Mar 26, 2011 at 9:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Per previous discussion, I'm going to wrap alpha5 Monday morning
Eastern time, barring objections.

It seems that the 'make distcheck' build is broken. ?Apparently we
don't have any automated testing of this? ?Anyone know what to fix
here?

Bruce keeps trying to put cross-references where they mustn't go ...

Actually those are all my fault. Sorry, I'm still learning the ropes.
I didn't realize xref couldn't be used in the release notes; it looks
like Bruce used <link> rather than <xref> for the things I used <xref>
for.

FYI, this is documented in release.sgml in an SGML comment:

For new features, add links to the documentation sections. Use </link>
not just </> so that generate_history.pl can remove it, so HISTORY.html
can be created without links to the main documentation. Don't use
<xref>.

<xref> can't be used because there is no text to keep, and </link> ( not
</>) has to be used so we remove the right tag.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +