removing =>(text, text) in 9.2

On Nov 1, 2011, at 11:19 AM, Robert Haas wrote:

Fair enough.

So, I tried to work up a patch for this, but I'm actually a bit
confused about what needs to be done here. I'll attach what I've got
so far as a starting point for discussion.

Looks reasonable, if verbose. (Yes, the extension design currently requires that). What about doc updates?

Best,

David

On Wed, Nov 2, 2011 at 12:36 AM, David E. Wheeler <david@kineticode.com> wrote:

On Nov 1, 2011, at 11:19 AM, Robert Haas wrote:

Fair enough.

So, I tried to work up a patch for this, but I'm actually a bit
confused about what needs to be done here.  I'll attach what I've got
so far as a starting point for discussion.

Looks reasonable, if verbose. (Yes, the extension design currently requires that). What about doc updates?

Hmm, I was kind of expecting that to be wrong at least in some minor way.

Here's a new version with documentation updates.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Robert Haas <robertmhaas@gmail.com> writes:

Hmm, I was kind of expecting that to be wrong at least in some minor way.

+/* contrib/hstore/hstore-1.0-1.1.sql */
+
+-- complain if script is sourced in psql, rather than via CREATE EXTENSION
+\echo Use "ALTER EXTENSION hstore" to load this file. \quit

You could mention ALTER EXTENSION hstore UPDATE TO 1.1; in this comment,
I think.

+++ b/contrib/hstore/hstore--1.1.sql
@@ -0,0 +1,524 @@
+/* contrib/hstore/hstore--1.0.sql */

That needs a comment update too.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

On Thu, Nov 3, 2011 at 10:18 AM, Dimitri Fontaine
<dimitri@2ndquadrant.fr> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

Hmm, I was kind of expecting that to be wrong at least in some minor way.

+/* contrib/hstore/hstore-1.0-1.1.sql */
+
+-- complain if script is sourced in psql, rather than via CREATE EXTENSION
+\echo Use "ALTER EXTENSION hstore" to load this file. \quit

You could mention ALTER EXTENSION hstore UPDATE TO 1.1; in this comment,
I think.

+++ b/contrib/hstore/hstore--1.1.sql
@@ -0,0 +1,524 @@
+/* contrib/hstore/hstore--1.0.sql */

That needs a comment update too.

Thanks for the review. New version attached.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Robert Haas <robertmhaas@gmail.com> writes:

Thanks for the review. New version attached.

This looks sane to me too (though I only read the patch and didn't
actually test upgrading).

regards, tom lane

On Mon, Nov 7, 2011 at 2:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

Thanks for the review.  New version attached.

This looks sane to me too (though I only read the patch and didn't
actually test upgrading).

OK, committed.

Thanks for the reviews, all.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company