pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

Started by Simon Riggsalmost 14 years ago6 messages
#1Simon Riggs
simon@2ndQuadrant.com

Correctly initialise shared recoveryLastRecPtr in recovery.
Previously we used ReadRecPtr rather than EndRecPtr, which was
not a serious error but caused pg_stat_replication to report
incorrect replay_location until at least one WAL record is replayed.

Fujii Masao

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5530623d0326e96e40b8d54275da256ca0fb6856

Modified Files
--------------
src/backend/access/transam/xlog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

#2Fujii Masao
masao.fujii@gmail.com
In reply to: Simon Riggs (#1)
Re: pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

On Fri, Jan 13, 2012 at 10:05 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

Correctly initialise shared recoveryLastRecPtr in recovery.
Previously we used ReadRecPtr rather than EndRecPtr, which was
not a serious error but caused pg_stat_replication to report
incorrect replay_location until at least one WAL record is replayed.

Thanks for the commit!

This needs to be backported to 9.1 and 9.0 because they also have
the same problem.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Fujii Masao (#2)
Re: [COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

On Mon, Jan 16, 2012 at 10:44 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

On Fri, Jan 13, 2012 at 10:05 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

Correctly initialise shared recoveryLastRecPtr in recovery.
Previously we used ReadRecPtr rather than EndRecPtr, which was
not a serious error but caused pg_stat_replication to report
incorrect replay_location until at least one WAL record is replayed.

Thanks for the commit!

This needs to be backported to 9.1 and 9.0 because they also have
the same problem.

http://archives.postgresql.org/message-id/14373.1328890248%40sss.pgh.pa.us

Minor version updates are scheduled to be released at the end of this month.
Before that, can you backport this commit to 9.1 and 9.0?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#4Fujii Masao
masao.fujii@gmail.com
In reply to: Fujii Masao (#3)
Re: [COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

On Mon, Feb 13, 2012 at 11:17 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

On Mon, Jan 16, 2012 at 10:44 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

On Fri, Jan 13, 2012 at 10:05 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

Correctly initialise shared recoveryLastRecPtr in recovery.
Previously we used ReadRecPtr rather than EndRecPtr, which was
not a serious error but caused pg_stat_replication to report
incorrect replay_location until at least one WAL record is replayed.

Thanks for the commit!

This needs to be backported to 9.1 and 9.0 because they also have
the same problem.

http://archives.postgresql.org/message-id/14373.1328890248%40sss.pgh.pa.us

Minor version updates are scheduled to be released at the end of this month.
Before that, can you backport this commit to 9.1 and 9.0?

[Reminder]
New minor version updates are about to be released in the next Monday.
Could you backport this commit to 9.1 and 9.0?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#5Simon Riggs
simon@2ndQuadrant.com
In reply to: Fujii Masao (#4)
Re: [COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

On Tue, Feb 21, 2012 at 4:46 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

[Reminder]
New minor version updates are about to be released in the next Monday.
Could you backport this commit to 9.1 and 9.0?

Sure

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fujii Masao (#4)
Re: Re: [COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

Fujii Masao <masao.fujii@gmail.com> writes:

[Reminder]
New minor version updates are about to be released in the next Monday.
Could you backport this commit to 9.1 and 9.0?

Note that Monday is not the deadline to get patches in; it's more like
tomorrow, if you'd like to see a full buildfarm cycle on your patch
before we wrap tarballs.

regards, tom lane