pgfiledump - pg_filedump: Updates for latest Postgres 9.2 sources.

Started by tglover 14 years ago3 messageshackerscommitters
Jump to latest
#1tgl
tgl@pgfoundry.org
hackerscommitters

Log Message:
-----------
Updates for latest Postgres 9.2 sources.
We no longer need pg_crc.c, and hence not a source tree, yay.

Modified Files:
--------------
pg_filedump:
Makefile (r1.3 -> r1.4)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgfiledump/pg_filedump/Makefile?r1=1.3&r2=1.4)
Makefile.contrib (r1.1.1.1 -> r1.2)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgfiledump/pg_filedump/Makefile.contrib?r1=1.1.1.1&r2=1.2)
README.pg_filedump (r1.2 -> r1.3)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgfiledump/pg_filedump/README.pg_filedump?r1=1.2&r2=1.3)
pg_filedump.c (r1.5 -> r1.6)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgfiledump/pg_filedump/pg_filedump.c?r1=1.5&r2=1.6)
pg_filedump.h (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgfiledump/pg_filedump/pg_filedump.h?r1=1.4&r2=1.5)

#2Alvaro Herrera
alvherre@commandprompt.com
In reply to: tgl (#1)
hackerscommitters
Re: [COMMITTERS] pgfiledump - pg_filedump: Updates for latest Postgres 9.2 sources.

Excerpts from tgl's message of lun mar 12 12:08:33 -0400 2012:

Log Message:
-----------
Updates for latest Postgres 9.2 sources.
We no longer need pg_crc.c, and hence not a source tree, yay.

FWIW I had some fun last week compiling this to 9.1 sources because I
was using a VPATH build. I had to add another -I to LDFLAGS or
something like that.

Also, what do you think about adding the ability to dump pg_filenode.map
files? Do you think it belongs in pg_filedump, or should we look at
doing that elsewhere? (Hmm, I just realized we might also conceivably
want to dump VM and FSM forks, too)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
hackerscommitters
pg_filedump improvements

Alvaro Herrera <alvherre@commandprompt.com> writes:

Also, what do you think about adding the ability to dump pg_filenode.map
files? Do you think it belongs in pg_filedump, or should we look at
doing that elsewhere?

Not sure. It does already contain the ability to dump pg_control, but
that seems like rather a wart (not to mention redundant with
pg_controldata) because you have to explicitly say -c to get it to
realize that's what you want. Map files would have to be another
special switch I think.

(Hmm, I just realized we might also conceivably
want to dump VM and FSM forks, too)

Yeah, that's been on the to-do list for awhile. There's not a way that
pg_filedump could automatically recognize such files, is there?

regards, tom lane