pgfiledump - pg_filedump: Updates for latest Postgres 9.2 sources.

Started by tglabout 14 years ago3 messageshackers
Jump to latest
#1tgl
tgl@pgfoundry.org
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: tgl (#1)
Re: [COMMITTERS] pgfiledump - pg_filedump: Updates for latest Postgres 9.2 sources.

Excerpts from tgl's message of lun mar 12 12:08:33 -0400 2012:

Log Message:
-----------
Updates for latest Postgres 9.2 sources.
We no longer need pg_crc.c, and hence not a source tree, yay.

FWIW I had some fun last week compiling this to 9.1 sources because I
was using a VPATH build. I had to add another -I to LDFLAGS or
something like that.

Also, what do you think about adding the ability to dump pg_filenode.map
files? Do you think it belongs in pg_filedump, or should we look at
doing that elsewhere? (Hmm, I just realized we might also conceivably
want to dump VM and FSM forks, too)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
pg_filedump improvements

Alvaro Herrera <alvherre@commandprompt.com> writes:

Also, what do you think about adding the ability to dump pg_filenode.map
files? Do you think it belongs in pg_filedump, or should we look at
doing that elsewhere?

Not sure. It does already contain the ability to dump pg_control, but
that seems like rather a wart (not to mention redundant with
pg_controldata) because you have to explicitly say -c to get it to
realize that's what you want. Map files would have to be another
special switch I think.

(Hmm, I just realized we might also conceivably
want to dump VM and FSM forks, too)

Yeah, that's been on the to-do list for awhile. There's not a way that
pg_filedump could automatically recognize such files, is there?

regards, tom lane