[PATCH] Patch to fix libecpg.so for isinf missing

Started by JiangGuiqingover 13 years ago4 messageshackers
Jump to latest
#1JiangGuiqing
jianggq@cn.fujitsu.com

hi

isinf() is not build to libecpg.so if build and install postgresql by
source on solaris9.
(isinf() is not contained within solaris9 system.)

bash-2.05$ nm /usr/local/pgsql/lib/libecpg.so | grep isinf
[215]: | 0| 0|FUNC |GLOB |0 |UNDEF |isinf

It(isinf missing) will causes ecpg program compile error such as follows.

bash-2.05$ ecpg test.pgc
bash-2.05$ cc -I/usr/local/pgsql/include -L/usr/local/pgsql/lib -lecpg
test.c -o test
Undefined first referenced
symbol in file
isinf /usr/local/pgsql/lib/libecpg.so
ld: fatal: Symbol referencing errors. No output written to test

I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
The diff file refer to the attachment "ecpglib-Makefile.patch".

Regards,
Jiang Guiqing

Attachments:

test.pgctext/plain; charset=Shift_JIS; name=test.pgcDownload
ecpglib-Makefile.patchtext/plain; charset=Shift_JIS; name=ecpglib-Makefile.patchDownload+2-2
#2Michael Meskes
meskes@postgresql.org
In reply to: JiangGuiqing (#1)
Re: [PATCH] Patch to fix libecpg.so for isinf missing

On Mon, Dec 03, 2012 at 01:12:48PM +0800, Jiang Guiqing wrote:

isinf() is not build to libecpg.so if build and install postgresql
by source on solaris9.
(isinf() is not contained within solaris9 system.)
...
I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
The diff file refer to the attachment "ecpglib-Makefile.patch".

Thanks for finding and fixing the problem, patch committed to HEAD and all 9.* branches.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Bruce Momjian
bruce@momjian.us
In reply to: Michael Meskes (#2)
Re: [PATCH] Patch to fix libecpg.so for isinf missing

On Tue, Dec 4, 2012 at 04:45:16PM +0100, Michael Meskes wrote:

On Mon, Dec 03, 2012 at 01:12:48PM +0800, Jiang Guiqing wrote:

isinf() is not build to libecpg.so if build and install postgresql
by source on solaris9.
(isinf() is not contained within solaris9 system.)
...
I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
The diff file refer to the attachment "ecpglib-Makefile.patch".

Thanks for finding and fixing the problem, patch committed to HEAD and all 9.* branches.

I have applied the attached patch to 9.0 to fix a merge conflict. I
patterned it after the commits you did to the other branches.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachments:

merge.difftext/x-diff; charset=us-asciiDownload+6-6
#4Michael Meskes
meskes@postgresql.org
In reply to: Bruce Momjian (#3)
Re: [PATCH] Patch to fix libecpg.so for isinf missing

On Tue, Dec 04, 2012 at 12:31:28PM -0500, Bruce Momjian wrote:

I have applied the attached patch to 9.0 to fix a merge conflict. I
patterned it after the commits you did to the other branches.

That is interesting. I fixed the same conflict and my git showed the commit,
but apparently that upush didn't work correctly. Sorry.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers