Bug in buildfarm client

Started by Christian Ullrichabout 13 years ago4 messages
#1Christian Ullrich
chris@chrullrich.net
1 attachment(s)

Hello all,

the extension modules (TestUpgrade etc.) in the buildfarm client do not
use the "make" command override defined in the config file, instead
hardcoding command lines using "make". This fails where make is not GNU
make.

Patch attached, which fixes the problem on jaguarundi.

--
Christian

Attachments:

buildfarm-gmake.difftext/plain; charset=windows-1252; name=buildfarm-gmake.diffDownload
*** /tmp/qvZogO_FileTextArrayFDW.pm	2012-12-04 08:31:46.878698514 +0100
--- PGBuild/Modules/FileTextArrayFDW.pm	2012-12-04 08:29:35.653265999 +0100
***************
*** 119,125 ****
  
      print main::time_str(), "building $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} make USE_PGXS=1";
  
      my @makeout = `cd $self->{where} && $cmd 2>&1`;
  
--- 119,125 ----
  
      print main::time_str(), "building $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} $self->{bfconf}->{make} USE_PGXS=1";
  
      my @makeout = `cd $self->{where} && $cmd 2>&1`;
  
***************
*** 136,142 ****
  
      print main::time_str(), "installing $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} make USE_PGXS=1 install";
  
      my @log = `cd $self->{where} && $cmd 2>&1`;
  
--- 136,142 ----
  
      print main::time_str(), "installing $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} $self->{bfconf}->{make} USE_PGXS=1 install";
  
      my @log = `cd $self->{where} && $cmd 2>&1`;
  
***************
*** 161,167 ****
  
      print main::time_str(), "install-checking $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} make USE_PGXS=1 installcheck";
  
      my @log = `cd $self->{where} && $cmd 2>&1`;
  
--- 161,167 ----
  
      print main::time_str(), "install-checking $MODULE\n" if	$verbose;
  
!     my $cmd = "PATH=../inst:$ENV{PATH} $self->{bfconf}->{make} USE_PGXS=1 installcheck";
  
      my @log = `cd $self->{where} && $cmd 2>&1`;
  
*** /tmp/3XAamk_TestUpgrade.pm	2012-12-04 08:31:46.886698485 +0100
--- PGBuild/Modules/TestUpgrade.pm	2012-12-04 08:28:38.007735375 +0100
***************
*** 67,73 ****
      }
      else
      {
!         my $cmd = "cd $self->{pgsql}/contrib/pg_upgrade && make check";
          @checklog = `$cmd 2>&1`;
      }
  
--- 67,73 ----
      }
      else
      {
!         my $cmd = "cd $self->{pgsql}/contrib/pg_upgrade && $self->{bfconf}->{make} check";
          @checklog = `$cmd 2>&1`;
      }
  
#2Andrew Dunstan
andrew@dunslane.net
In reply to: Christian Ullrich (#1)
Re: Bug in buildfarm client

On 12/04/2012 02:40 AM, Christian Ullrich wrote:

Hello all,

the extension modules (TestUpgrade etc.) in the buildfarm client do
not use the "make" command override defined in the config file,
instead hardcoding command lines using "make". This fails where make
is not GNU make.

Patch attached, which fixes the problem on jaguarundi.

Thanks, I will fix it, but this is not the right mailing list for
buildfarm client bugs. You should be on the pgbuildfarm-members list.
See <http://pgfoundry.org/mailman/listinfo/pgbuildfarm-members&gt;

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Christian Ullrich
chris@chrullrich.net
In reply to: Andrew Dunstan (#2)
Re: Bug in buildfarm client

* Andrew Dunstan wrote:

On 12/04/2012 02:40 AM, Christian Ullrich wrote:

the extension modules (TestUpgrade etc.) in the buildfarm client do
not use the "make" command override defined in the config file,

Patch attached, which fixes the problem on jaguarundi.

Thanks, I will fix it, but this is not the right mailing list for
buildfarm client bugs. You should be on the pgbuildfarm-members list.

I'm sorry. I checked the archives, saw next to nothing in the last few
months, and thought that maybe I should use a different list instead.

--
Christian

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Christian Ullrich (#3)
Re: Bug in buildfarm client

On 12/04/2012 08:35 AM, Christian Ullrich wrote:

* Andrew Dunstan wrote:

On 12/04/2012 02:40 AM, Christian Ullrich wrote:

the extension modules (TestUpgrade etc.) in the buildfarm client do
not use the "make" command override defined in the config file,

Patch attached, which fixes the problem on jaguarundi.

Thanks, I will fix it, but this is not the right mailing list for
buildfarm client bugs. You should be on the pgbuildfarm-members list.

I'm sorry. I checked the archives, saw next to nothing in the last few
months, and thought that maybe I should use a different list instead.

It's a very low-traffic list :-)

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers