Typo in documentation for function to_json

Started by Michael Paquieralmost 13 years ago5 messages
#1Michael Paquier
michael.paquier@gmail.com
1 attachment(s)

Hi all,

While reading some documentation about json functions, I found a typo with
the example used with function to_json. A bracket was missing. Please find
attached the patch correcting that.

Regards,
--
Michael

Attachments:

20120403_to_json_typo.patchapplication/octet-stream; name=20120403_to_json_typo.patchDownload
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index dc5941e..0d152bb 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -9967,7 +9967,7 @@ table2-mapping
          a boolean or NULL, the text representation will be used, escaped and
          quoted so that it is legal JSON.
        </entry>
-       <entry><literal>to_json('Fred said "Hi."'</literal></entry>
+       <entry><literal>to_json('Fred said "Hi."')</literal></entry>
        <entry><literal>"Fred said \"Hi.\""</literal></entry>
       </row>
       <row>
#2Andrew Dunstan
andrew@dunslane.net
In reply to: Michael Paquier (#1)
Re: Typo in documentation for function to_json

On 04/03/2013 09:22 AM, Michael Paquier wrote:

Hi all,

While reading some documentation about json functions, I found a typo
with the example used with function to_json. A bracket was missing.
Please find attached the patch correcting that.

I have a patch for this and other docs errors waiting in the wings. I
will commit it when the current hiatus is done, some time tomorrow.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Michael Paquier
michael.paquier@gmail.com
In reply to: Andrew Dunstan (#2)
Re: Typo in documentation for function to_json

On Wed, Apr 3, 2013 at 10:32 PM, Andrew Dunstan <andrew@dunslane.net> wrote:

I have a patch for this and other docs errors waiting in the wings. I will
commit it when the current hiatus is done, some time tomorrow.

OK thanks.
--
Michael

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#2)
Re: Typo in documentation for function to_json

Andrew Dunstan <andrew@dunslane.net> writes:

I have a patch for this and other docs errors waiting in the wings. I
will commit it when the current hiatus is done, some time tomorrow.

There's no reason not to commit now. The blockage is on propagation to
the anongit mirror, not on what committers can do.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#4)
Re: Typo in documentation for function to_json

On 04/03/2013 10:11 AM, Tom Lane wrote:

Andrew Dunstan <andrew@dunslane.net> writes:

I have a patch for this and other docs errors waiting in the wings. I
will commit it when the current hiatus is done, some time tomorrow.

There's no reason not to commit now. The blockage is on propagation to
the anongit mirror, not on what committers can do.

True, but there's no great advantage either. I am not planning to commit
anything else before then, and I like to check the committers email when
I commit to make sure everything is kosher.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers