compiler warning in UtfToLocal and LocalToUtf (conv.c)
Hello,
in the current master head (4cbe3ac3e86790d05c569de4585e5075a62a9b41),
I've noticed the compiler warnings in src/backend/utils/mb/conv.c
conv.c: In function �UtfToLocal�:
conv.c:252:23: error: �iutf� may be used uninitialized in this function
[-Werror=maybe-uninitialized]
...
conv.c: In function �LocalToUtf�:
conv.c:301:23: error: �iiso� may be used uninitialized in this function
[-Werror=maybe-uninitialized]
...
The compiler doesn't know that the 'l' may varies between 1 and 4. Hot
fix may be:
1. preinitialize it
2. delete last if statement (change else-if to else)
3. change it to switch-case and set default behaviour
Regards,
Karol
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Karol Trzcionka <karlikt@gmail.com> writes:
in the current master head (4cbe3ac3e86790d05c569de4585e5075a62a9b41),
I've noticed the compiler warnings in src/backend/utils/mb/conv.c
Hm, what compiler version are you using? I've never seen such a warning
(and that code hasn't changed in some time).
I agree the code could stand to be fixed, but I'm just curious as to
why this is only being seen now.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
W dniu 19.07.2013 02:42, Tom Lane pisze:
Hm, what compiler version are you using? I've never seen such a
warning (and that code hasn't changed in some time).
gcc version 4.8.1 20130612 (Red Hat 4.8.1-2) (GCC)
Regards,
Karol
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers