pgsql: Move rmtree() from libpgport to libpgcommon

Started by Peter Eisentrautabout 12 years ago2 messages
#1Peter Eisentraut
peter_e@gmx.net

Move rmtree() from libpgport to libpgcommon

It requires pgfnames() from libpgcommon.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2e6bc4b806ca92433932b34c019293a201f03e11

Modified Files
--------------
src/bin/initdb/nls.mk | 2 +-
src/common/Makefile | 2 +-
src/common/rmtree.c | 131 +++++++++++++++++++++++++++++++++++++++++++
src/port/dirmod.c | 110 ------------------------------------
src/tools/msvc/Mkvcbuild.pm | 2 +-
5 files changed, 134 insertions(+), 113 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: [COMMITTERS] pgsql: Move rmtree() from libpgport to libpgcommon

Peter Eisentraut <peter_e@gmx.net> writes:

Move rmtree() from libpgport to libpgcommon

This patch leaves dirmod.c entirely empty on non-Windows platforms.
At least on my OS X Lion laptop, that results in some bleating:

/usr/bin/ranlib: file: libpgport.a(dirmod.o) has no symbols
/usr/bin/ranlib: file: libpgport_srv.a(dirmod_srv.o) has no symbols

Can we do something about that? Perhaps not build this file on
non-Windows?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers