[PATCH] Doc fix for VACUUM FREEZE

Started by Maciek Sakrejdaover 12 years ago6 messageshackers
Jump to latest
#1Maciek Sakrejda
m.sakrejda@gmail.com

VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age
to 0, but only the former is documented. This patch notes that the other
setting is also affected.

#2Maciek Sakrejda
m.sakrejda@gmail.com
In reply to: Maciek Sakrejda (#1)
Re: [PATCH] Doc fix for VACUUM FREEZE

(now with patch--sorry about that)

Attachments:

correct-vacuum-freeze-docs.patchtext/x-diff; charset=US-ASCII; name=correct-vacuum-freeze-docs.patchDownload+3-2
#3Amit Kapila
amit.kapila16@gmail.com
In reply to: Maciek Sakrejda (#2)
Re: [PATCH] Doc fix for VACUUM FREEZE

On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda <m.sakrejda@gmail.com> wrote:

VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected.
(now with patch--sorry about that)

Your explanation and patch seems fine to me.
Kindly submit your patch in Open CommitFest
(https://commitfest.postgresql.org/action/commitfest_view?id=21).

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Maciek Sakrejda (#2)
Re: [PATCH] Doc fix for VACUUM FREEZE

On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:

(now with patch--sorry about that)

This patch doesn't apply.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Amit Kapila
amit.kapila16@gmail.com
In reply to: Peter Eisentraut (#4)
Re: [PATCH] Doc fix for VACUUM FREEZE

On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:

(now with patch--sorry about that)

This patch doesn't apply.

There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.

I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachments:

correct-vacuum-freeze-docs_v2.patchapplication/octet-stream; name=correct-vacuum-freeze-docs_v2.patchDownload+3-2
#6Robert Haas
robertmhaas@gmail.com
In reply to: Amit Kapila (#5)
Re: [PATCH] Doc fix for VACUUM FREEZE

On Tue, Jan 14, 2014 at 2:39 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:

On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:

(now with patch--sorry about that)

This patch doesn't apply.

There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.

I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.

Committed with a grammatical correction.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers