[PATCH] Doc fix for VACUUM FREEZE
VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age
to 0, but only the former is documented. This patch notes that the other
setting is also affected.
(now with patch--sorry about that)
Attachments:
correct-vacuum-freeze-docs.patchtext/x-diff; charset=US-ASCII; name=correct-vacuum-freeze-docs.patchDownload
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index eb71581..5f03343 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -100,8 +100,9 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] ANALYZE [ <replaceable class="PARAMETER">
<para>
Selects aggressive <quote>freezing</quote> of tuples.
Specifying <literal>FREEZE</literal> is equivalent to performing
- <command>VACUUM</command> with the
- <xref linkend="guc-vacuum-freeze-min-age"> parameter
+ <command>VACUUM</command> with both
+ <xref linkend="guc-vacuum-freeze-table-age"> and
+ <xref linkend="guc-vacuum-freeze-min-age">
set to zero.
</para>
</listitem>
On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda <m.sakrejda@gmail.com> wrote:
VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected.
(now with patch--sorry about that)
Your explanation and patch seems fine to me.
Kindly submit your patch in Open CommitFest
(https://commitfest.postgresql.org/action/commitfest_view?id=21).
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
(now with patch--sorry about that)
This patch doesn't apply.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
(now with patch--sorry about that)
This patch doesn't apply.
There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.
I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachments:
correct-vacuum-freeze-docs_v2.patchapplication/octet-stream; name=correct-vacuum-freeze-docs_v2.patchDownload
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index 1e98473..b4524be 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -100,8 +100,9 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] ANALYZE [ <replaceable class="PARAMETER">
<para>
Selects aggressive <quote>freezing</quote> of tuples.
Specifying <literal>FREEZE</literal> is equivalent to performing
- <command>VACUUM</command> with the
- <xref linkend="guc-vacuum-freeze-min-age"> parameter
+ <command>VACUUM</command> with both
+ <xref linkend="guc-vacuum-freeze-min-age"> and
+ <xref linkend="guc-vacuum-freeze-table-age"> parameters
set to zero. Aggressive freezing is always performed when the
table is rewritten, so this option is redundant when <literal>FULL</>
is specified.
On Tue, Jan 14, 2014 at 2:39 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
(now with patch--sorry about that)
This patch doesn't apply.
There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.
Committed with a grammatical correction.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers