Wrong comment for bitncmp function in network.c

Started by Emre Hasegeliabout 12 years ago2 messages
#1Emre Hasegeli
emre@hasegeli.com

I am not sure it worth reporting but it took me a while to find out
what is wrong with comparing two values returned from
the bitncmp function. It does not return -1, 1 or 0 as it is written
on the comment when n % 8 == 0.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Emre Hasegeli (#1)
Re: Wrong comment for bitncmp function in network.c

Emre Hasegeli <emre@hasegeli.com> writes:

I am not sure it worth reporting but it took me a while to find out
what is wrong with comparing two values returned from
the bitncmp function. It does not return -1, 1 or 0 as it is written
on the comment when n % 8 == 0.

Yeah, should say "<0, >0, or 0", I guess. Will fix, thanks.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers