pgsql: Add TAP tests for client programs

Started by Peter Eisentrautover 11 years ago7 messages
#1Peter Eisentraut
peter_e@gmx.net

Add TAP tests for client programs

Reviewed-by: Pavel Stěhule <pavel.stehule@gmail.com>
Reviewed-by: Erik Rijkers <er@xs4all.nl>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7d0f493f19607774fdccb1a1ea06fdd96a3d9698

Modified Files
--------------
GNUmakefile.in | 4 +-
configure | 47 ++++++
configure.in | 5 +
doc/src/sgml/installation.sgml | 3 +-
doc/src/sgml/regress.sgml | 28 ++++
src/Makefile.global.in | 16 ++
src/bin/initdb/.gitignore | 2 +
src/bin/initdb/Makefile | 7 +
src/bin/initdb/t/001_initdb.pl | 37 +++++
src/bin/pg_basebackup/.gitignore | 2 +
src/bin/pg_basebackup/Makefile | 6 +
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 90 ++++++++++++
src/bin/pg_basebackup/t/020_pg_receivexlog.pl | 8 +
src/bin/pg_config/.gitignore | 1 +
src/bin/pg_config/Makefile | 6 +
src/bin/pg_config/t/001_pg_config.pl | 12 ++
src/bin/pg_controldata/.gitignore | 1 +
src/bin/pg_controldata/Makefile | 6 +
src/bin/pg_controldata/t/001_pg_controldata.pl | 14 ++
src/bin/pg_ctl/.gitignore | 1 +
src/bin/pg_ctl/Makefile | 6 +
src/bin/pg_ctl/t/001_start_stop.pl | 25 ++++
src/bin/pg_ctl/t/002_status.pl | 19 +++
src/bin/scripts/.gitignore | 2 +
src/bin/scripts/Makefile | 7 +
src/bin/scripts/t/010_clusterdb.pl | 18 +++
src/bin/scripts/t/011_clusterdb_all.pl | 9 ++
src/bin/scripts/t/020_createdb.pl | 16 ++
src/bin/scripts/t/030_createlang.pl | 18 +++
src/bin/scripts/t/040_createuser.pl | 26 ++++
src/bin/scripts/t/050_dropdb.pl | 16 ++
src/bin/scripts/t/060_droplang.pl | 15 ++
src/bin/scripts/t/070_dropuser.pl | 16 ++
src/bin/scripts/t/080_pg_isready.pl | 15 ++
src/bin/scripts/t/090_reindexdb.pl | 21 +++
src/bin/scripts/t/091_reindexdb_all.pl | 11 ++
src/bin/scripts/t/100_vacuumdb.pl | 17 +++
src/bin/scripts/t/101_vacuumdb_all.pl | 9 ++
src/test/perl/TestLib.pm | 186 ++++++++++++++++++++++++
39 files changed, 745 insertions(+), 3 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

Peter Eisentraut <peter_e@gmx.net> writes:

Add TAP tests for client programs

I assume the buildfarm would need to be taught about this?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#2)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

On 04/14/2014 10:17 PM, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Add TAP tests for client programs

I assume the buildfarm would need to be taught about this?

Yes. It probably won't be a huge change, but it will need a bit of code.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Andrew Dunstan (#3)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

On 04/14/2014 10:30 PM, Andrew Dunstan wrote:

On 04/14/2014 10:17 PM, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Add TAP tests for client programs

I assume the buildfarm would need to be taught about this?

Yes. It probably won't be a huge change, but it will need a bit of code.

And it won't work on most or all Windows machines, since they almost
certainly won't have IPC::Run installed.

That's *very* annoying.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Peter Eisentraut
peter_e@gmx.net
In reply to: Andrew Dunstan (#3)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

On 4/14/14, 10:30 PM, Andrew Dunstan wrote:

On 04/14/2014 10:17 PM, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Add TAP tests for client programs

I assume the buildfarm would need to be taught about this?

Yes. It probably won't be a huge change, but it will need a bit of code.

It might be more future-proof if the build farm just called make
check-world and used some other way to identify the individual tests in
that output. Otherwise, we'll need a new build farm release every time
a test suite is added.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#5)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

Peter Eisentraut <peter_e@gmx.net> writes:

On 4/14/14, 10:30 PM, Andrew Dunstan wrote:

Yes. It probably won't be a huge change, but it will need a bit of code.

It might be more future-proof if the build farm just called make
check-world and used some other way to identify the individual tests in
that output. Otherwise, we'll need a new build farm release every time
a test suite is added.

That argument would be more convincing if "make check-world" worked
on Windows ...

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#7Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#6)
Re: [COMMITTERS] pgsql: Add TAP tests for client programs

On 4/15/14, 11:11 PM, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

On 4/14/14, 10:30 PM, Andrew Dunstan wrote:

Yes. It probably won't be a huge change, but it will need a bit of code.

It might be more future-proof if the build farm just called make
check-world and used some other way to identify the individual tests in
that output. Otherwise, we'll need a new build farm release every time
a test suite is added.

That argument would be more convincing if "make check-world" worked
on Windows ...

What about it doesn't work on Windows?

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers