pg_recvlogical not accepting -I to specify start LSN position
Hi all,
As written in subject, pg_recvlogical does not work properly with
option -I but it should:
$ pg_recvlogical -I 0/0
pg_recvlogical: invalid option -- I
Try "pg_recvlogical --help" for more information.
$ pg_recvlogical --help | grep "\-I"
-I, --startpos=PTR where in an existing slot should the streaming start
Attached patch corrects that, reshuffling at the same time the option
letters parsed with getopt_long in alphabetical order.
Regards,
--
Michael
Attachments:
20140525_pg_recvlogical_opts.patchtext/x-patch; charset=US-ASCII; name=20140525_pg_recvlogical_opts.patchDownload+1-1
Hi,
On 2014-05-25 22:35:24 +0900, Michael Paquier wrote:
As written in subject, pg_recvlogical does not work properly with
option -I but it should:
$ pg_recvlogical -I 0/0
pg_recvlogical: invalid option -- I
Try "pg_recvlogical --help" for more information.
$ pg_recvlogical --help | grep "\-I"
-I, --startpos=PTR where in an existing slot should the streaming start
Good catch. Apparently only the long argument version ever worked...
Attached patch corrects that, reshuffling at the same time the option
letters parsed with getopt_long in alphabetical order.
Hm. Not a big fan of this in isolation. In the attached patch I've
reordered the options to all be ordered alphabetically, but only inside
the section they are in --help.
What do you think?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
0001-Fix-pg_recvlogical-to-accept-the-documented-I-instea.patchtext/x-patch; charset=us-asciiDownload+25-26
On Mon, May 26, 2014 at 2:01 AM, Andres Freund <andres@2ndquadrant.com> wrote:
On 2014-05-25 22:35:24 +0900, Michael Paquier wrote:
Attached patch corrects that, reshuffling at the same time the option
letters parsed with getopt_long in alphabetical order.Hm. Not a big fan of this in isolation. In the attached patch I've
reordered the options to all be ordered alphabetically, but only inside
the section they are in --help.What do you think?
That's fine as well. Thanks.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers