9.5 CF1

On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Robert Haas wrote:

On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

Yes, please don't do that. A simple, normal reply to the message that
submits the patch is much better from my point of view as a subsequent
reviewer and committer.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

Robert Haas wrote:

On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

Yes, please don't do that. A simple, normal reply to the message that
submits the patch is much better from my point of view as a subsequent
reviewer and committer.

Worth noting also is that Magnus is working on a new version of the
commitfest app that will be able to automatically keep track of threads
about patches --- so long as they *are* threads according to our mailing
list archives. I'm not sure if the archives recognize replies with a
changed Subject: as being the same thread or not.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On 2014-06-17 12:47:19 -0400, Alvaro Herrera wrote:

Robert Haas wrote:

On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

Yes, please don't do that. A simple, normal reply to the message that
submits the patch is much better from my point of view as a subsequent
reviewer and committer.

Very much agreed. Especially as many patches have several reviews over
the course of their integration. I think the separate thread suggestion
was made by some former CF manager?

I think it's sometimes, for larger/hotly debated patches, useful to
start anew at significant new version though... 300 message deep threads
get unwiedly.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

At 2014-06-17 12:47:19 -0400, alvherre@2ndquadrant.com wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll
be easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

Yes, please don't do that. A simple, normal reply to the message that
submits the patch is much better from my point of view as a subsequent
reviewer and committer.

I find it hard to believe that gmail is incapable of threading messages
using In-Reply-To/References header fields, especially given that mail
subjects are changed all the time in the normal course of events. But
I'll take your word for it and reply to the original message (as I've
always done) without changing the Subject for any reviews I post.

Only one other person took my suggestion so far, but if anyone else is
tempted to do the same: consider the recommendation withdrawn.

-- Abhijit

P.S. I also realise now that some people may not {,be able to} change
the Subject of a message without creating an entirely new thread.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Abhijit Menon-Sen wrote:

I find it hard to believe that gmail is incapable of threading messages
using In-Reply-To/References header fields, especially given that mail
subjects are changed all the time in the normal course of events. But
I'll take your word for it and reply to the original message (as I've
always done) without changing the Subject for any reviews I post.

They do it -- I experimented with it awhile ago. Gmail threads emails
perfectly well, but it seems they break threads on purpose when the
subject changes. Apparently, more people is used to starting a new
thread by replying to an existing email and changing to a new subject,
than people "tweak" subjects by adding tags and such.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Tue, Jun 17, 2014 at 6:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

Robert Haas wrote:

On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams@2ndquadrant.com>

wrote:

P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
easier to keep track of them.

I and, I believe, various other people hate that style, because at
least in Gmail, it breaks the threading. It is much easier to find
things if they are all posted on one thread.

Yes, please don't do that. A simple, normal reply to the message that
submits the patch is much better from my point of view as a subsequent
reviewer and committer.

Worth noting also is that Magnus is working on a new version of the
commitfest app that will be able to automatically keep track of threads
about patches --- so long as they *are* threads according to our mailing
list archives. I'm not sure if the archives recognize replies with a
changed Subject: as being the same thread or not.

The archives code does threading based on the headers (in-reply-to and
references, in priority order). It completely ignores the subject when it
comes to the threading.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Hi.

One week into the CommitFest, we now have nine committed patches, ten
ready for committer, fourteen waiting on their author, and fifty-nine
still awaiting review.

Thanks to all the people who submitted a review (and a special mention
for MauMau for reviewing the most patches so far, of which one has been
committed and three others are ready for committer).

There are still twenty-one patches that do not have a reviewer. Here's
a selection:

KNN-GiST with recheck
http://archives.postgresql.org/message-id/CAPpHfdu_qBLNRnv-r=_tofZYYa6-r=Z5_MGF4_phAOkWcYxfRg@mail.gmail.com

XLogLockBlockRangeForCleanup
http://archives.postgresql.org/message-id/20140613084012.GA16567@toroid.org

UPDATE/DELETE .. ORDER BY .. LIMIT ..
http://archives.postgresql.org/message-id/1394662740.69204.YahooMailNeo@web163002.mail.bf1.yahoo.com

event triggers: more DROP info
http://archives.postgresql.org/message-id/20140613195049.GQ18688@eldon.alvh.no-ip.org

WAL format & API changes
http://archives.postgresql.org/message-id/539CBA75.3050802@vmware.com

Please feel free to contact me with questions.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Hi.

We're two weeks into the CommitFest now, and things are moving along
quite nicely.

Fourteen patches have been committed, and twelve more are marked ready
for committer. But most importantly, many patches have been reviewed,
and only nine patches still lack a reviewer (and most of those have
seen some discussion already).

I have sent a number of reminders and status inquiries by private mail,
and will continue to do so for "waiting on author" and "needs review"
patches. (Living as I do at the edge of a forest, I have also curated
a fine selection of sharp sticks to poke people with if they don't
respond during the week.)

Here's a list of the patches that have no listed reviewers:

Buffer capture facility: check WAL replay consistency
http://archives.postgresql.org/message-id/CAB7nPqTFK4=fcrto=Lji4VLBX9AH+FV1Z1Ke6r98PpXuUXWeNA@mail.gmail.com

Generic atomics implementation
http://archives.postgresql.org/message-id/20140625171434.GG24114@awork2.anarazel.de

KNN-GiST with recheck
http://archives.postgresql.org/message-id/CAPpHfdu_qBLNRnv-r=_tofZYYa6-r=Z5_MGF4_phAOkWcYxfRg@mail.gmail.com

Sort support for text with strxfrm() poor man's keys
http://archives.postgresql.org/message-id/CAM3SWZQKwELa58h1R9sxwAOCJpgs=xJbiu7apDyq9pUuSfQX6g@mail.gmail.com

Use unique index for longer pathkeys
http://archives.postgresql.org/message-id/20140613.164133.160845727.horiguchi.kyotaro@lab.ntt.co.jp

CSN snapshots
http://archives.postgresql.org/message-id/539AD153.9000004@vmware.com

Postgres Hibernator contrib module
http://archives.postgresql.org/message-id/CABwTF4XGbpgwmkKt6ezSFVnpF11KmAg5m969twkGoDhnPj-QLA@mail.gmail.com

possibility to set "double" style for unicode lines
http://archives.postgresql.org/message-id/CAFj8pRCzNo6kP3vyuZAJkakpcfb_aBRhSRaLcgjUjmpXno9M3A@mail.gmail.com

Refactor SSL code to support other SSL implementations
http://archives.postgresql.org/message-id/53986CF4.1030403@vmware.com

Does anyone want to pick up one of these?

Thanks to everyone for their participation. It's especially nice to see
several reviews posted, and the authors responding quickly with updated
versions of their patch to address the review comments.

As always, please feel free to contact me with questions.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Hi.

Here's a detailed mid-week update split up by category. I've left out
patches marked returned/rejected, committed, or ready for committer.

Server features
---------------

Lag & Lead Window Functions Can Ignore Nulls
Latest patch currently pending review by Jeff and �lvaro. No
updates so far.

Foreign table inheritance
Moved from ready for committer back to waiting on author after
Noah's review comments. Should we expect an updated patch to be
posted in this CF?

http://archives.postgresql.org/message-id/20140702022327.GC1586927@tornado.leadboat.com

Using Levenshtein distance to HINT a candidate column name
No real progress in any direction. Everyone wants the feature, but
nobody is sure how many suggestions would be useful and how many
would be annoying.

Buffer capture facility: check WAL replay consistency
Some discussion, but no reviewers. Status unclear.

http://archives.postgresql.org/message-id/CAB7nPqTFK4=fcrto=Lji4VLBX9AH+FV1Z1Ke6r98PpXuUXWeNA@mail.gmail.com

Custom Plan API
Shigeru Hanada has said he plans to post a design review soon.

delta relations in AFTER triggers
No code review yet, but there's a proof-of-concept extension that
uses the feature, and Kevin is working on PL changes to make the
feature usable, and hopes to commit in this cycle.

Minmax indexes
�lvaro will respond to the design questions Heikki raised.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Miscellaneous
-------------

contrib/fastbloat - tool for quickly assessing bloat stats for a table
Pending review by Jaime.

showing index update time on EXPLAIN
Pending updated patch by Jaime.

idle_in_transaction_session_timeout
Marked as ready for committer, but as far as I can tell the patch
needs revisions per Tom's comments. It's unclear if Vik is working
on these, or Kevin, or nobody. Anyone?

logging of replication commands
Two patches posted: one generally accepted, the other contentious.
Pending status update.

Refactor SSL code to support other SSL implementations
Some discussion, but no code reviews yet. Jeff Janes tried it and it
hung; Andreas Karlsson fixed it and it worked for him. Everyone does
seem to agree that it's a good idea.

There is also one other "ready for committer" patch in this category.

Bug fixes
---------

Correctly place DLLs for ECPG apps in bin folder
Pending review by Muhammad Asif Naeem.

Per table autovacuum vacuum cost parameters behavior change
Pending review by �lvaro.

Ignore Ctrl-C/Break on Windows
Christian Ullrich has said he will post an updated patch this week.

There are also three "ready for committer" patches in this category.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Tue, Jul 1, 2014 at 10:06 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

Using Levenshtein distance to HINT a candidate column name
No real progress in any direction. Everyone wants the feature, but
nobody is sure how many suggestions would be useful and how many
would be annoying.

Expect a revised patch soon.

--
Peter Geoghegan

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Functions
---------

min/max support for inet datatypes
Pending review by Muhammad Asif Naeem.

Selectivity estimation for inet operators
Dilip Kumar plans to post a review this week.

There are two "ready for committer" patches in this category.

Clients
-------

Gaussian distribution pgbench
Fabien Coelho plans to post a review of the latest patch.

possibility to set "double" style for unicode lines
No reviews, no reviewers. \N{DOUBLE LINED UNHAPPY FACE}[1]

Allow parallel cores to be used by vacuumdb
Status not entirely clear. Do we want this? Does the patch have
too much duplicated code? Can it be fixed in this cycle?

add line number as prompt option to psql
Sawada Masahiko plans to post an updated patch soon.

There are three "ready for committer" patches in this category.

-- Abhijit

1. Not a real Unicode character. Sorry.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

System administration
---------------------

pg_hibernator
Nice feature, some discussion, no code reviews. Status not entirely
clear, but updated patch available.

Monitoring & control
--------------------

Reducing impact of hints/cleanup for SELECTs
Pending performance review by Emanuel Calvo. (He said he's posted a
review, but I couldn't find it. He's travelling right now, will send
me a pointer later.)

Send transaction commit/rollback stats to the stats collector
unconditionally
Currently marked waiting on author, but I think Kevin is in the
process of getting it committed.

issue log message to suggest VACUUM FULL if a table is nearly empty
Euler has said he plans to post a review this week.

pg_shmem_allocations view
Euler has said he plans to post a review this week.

pg_xlogdump --stats
Pending review by Dilip Kumar (who plans to post a review this
week), but Osamu Furuya and Marti Raudsepp have said it looks
OK generally.

There is one "ready for committer" patch in this category.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Security
--------

Row-security based on Updatable security barrier views
Lots of discussion that I haven't dared to look at properly yet. I
gather there's still plenty of design-level work needed, and this
is not in any imminent danger of being committed.

Replication & Recovery
----------------------

pg_receivexlog add synchronous mode
Patch works, is generally acceptable. Fujii-san proposed a
refactoring patch to be applied before this one, and plans
to commit it soon.

Compression of Full Page Writes
Currently under development, timeline unclear. Probably needs to be
marked returned with feedback and moved to August CF.

WAL format & API changes
I'm not sure what's happening here. Will look more closely, but
updates are welcome from the people who've been participating in
the discussion/review.

There are three "ready for committer" patches in this category.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

SQL commands
------------

Event triggers: object creation support
Enormous patch, no reviews, no reviewers, but it's known to work
already. Does anyone want to have a look at this? (I thought it
was being reviewed, and didn't realise otherwise until a couple
of days ago. Sorry about that.)

change alter user to be a true alias for alter role
Original patch worked (Vik) but didn't go far enough towards
preventing future repetitions of the mistake (Tom) but the suggested
change didn't turn out to be easy (Vik). I don't think anyone is
working on this at the moment.

IMPORT FOREIGN SCHEMA statement
Lots of discussion and various revisions; currently marked waiting
on author. Updates welcome.

"RETURNING PRIMARY KEY" syntax extension
Patch works and has been revised as suggested. Some questions about
how useful it is. Updates welcome.

Allow an unlogged table to be changed to logged GSoC 2014
Stephen has looked at the patch a little, but isn't sure how much
time he'll have to complete the review. More eyes are welcome. I
recommend this patch to anyone who's looking to get started with
reviewing something substantial: it looks very nicely-done and
straightforward, but still non-trivial.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Performance
-----------

scalable LWLocks
Generic atomics implementation
Both under active discussion.

KNN-GiST with recheck
Partial sort
Some earlier discussion, but no conclusions, and as far as I know
nobody is working on these patches at the moment.

lowering array_agg memory requirements
I'm waiting to hear from Tomas if he expects to post an updated
version of the patch soon. Otherwise I'll move it to 2014-08.

Don't require a NBuffer sized PrivateRefCount array of local buffer pins
Pending performance tests before commit. Is anyone working on this?

Allow more join types to be removed
Updated patch pending review from Simon. Updates welcome.

Sort support for text with strxfrm() poor man's keys
Lots of earlier discussion, but no conclusions as far as I can tell.
Does anyone want to take a look at this?

Scaling shared buffer eviction
Pending review by Andres. Any updates?

Spread shared memory across NUMA memory nodes
Marked waiting on author, but status unclear. Any updates?

Use unique index for longer pathkeys
No reviews, no reviewers. I took a quick look, and it's not clear if
this is useful in itself, or if it just enables more interesting
optimisations later. Does anyone want to look at this?

XLogLockBlockRangeForCleanup
Amit Khandekar plans to post a review this week.

SKIP LOCKED
Two patches available: original by Simon, updated/merged version by
Thomas Munro. Simon said he'll look into both with a view towards
committing the functionality. Timeline not yet clear.

Allow NOT IN to use anti joins
Revised patch marked pending review. Updates welcome.

CSN snapshots
Work in progress, plenty of discussion, no reviews. Probably nothing
to do here. (Heikki, are you waiting for feedback or anything?)

There's not even one "ready for committer" patch in this category.

-- Abhijit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Jul 2, 2014 at 2:44 PM, Abhijit Menon-Sen <ams@2ndquadrant.com>
wrote:

WAL format & API changes
I'm not sure what's happening here. Will look more closely, but
updates are welcome from the people who've been participating in
the discussion/review.

Patch has been reviewed once. Heikki has submitted an updated that still
has some issues, nothing unbearable though IMO. I imagine that there are
still some discussions needed for the potention performance drop that this
patch could create because of the individual memcpy calls that are
performed for each WAL record registration.
Regards,
--
Michael

(2014/07/02 14:06), Abhijit Menon-Sen wrote:

Foreign table inheritance
Moved from ready for committer back to waiting on author after
Noah's review comments. Should we expect an updated patch to be
posted in this CF?

http://archives.postgresql.org/message-id/20140702022327.GC1586927@tornado.leadboat.com

Noah, thank you for the review!

In addition to the issues pointed out by Noah, the following should be
resolved, I think. And ISTM we should work on the latter first, for
which I plan to add a separate patch to the next CF. So, I think it
would be better to move this to the next CF.

/messages/by-id/3492.1404136084@sss.pgh.pa.us

Thanks,

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers