pg_filedump for 9.4?

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org> writes:

Will there be a pg_filedump for 9.4? I'd like to finish package tests
before we release 9.4.0.

Probably, but I have no time for it right now.

FWIW, I believe the current "9.3" sources still work with HEAD/9.4.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Jun 25, 2014 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org> writes:

Will there be a pg_filedump for 9.4? I'd like to finish package tests
before we release 9.4.0.

Probably, but I have no time for it right now.

FWIW, I believe the current "9.3" sources still work with HEAD/9.4.

I'll check it and post the results.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com> writes:

On Wed, Jun 25, 2014 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org> writes:

Will there be a pg_filedump for 9.4? I'd like to finish package tests
before we release 9.4.0.

Probably, but I have no time for it right now.
FWIW, I believe the current "9.3" sources still work with HEAD/9.4.

I'll check it and post the results.

I forgot to mention that thanks to Christoph Berg, the pg_filedump sources
have gotten off pgfoundry and onto git.postgresql.org. If anyone's got
bandwidth for working on it (in particular, merging the checksum-testing
code that was posted awhile back), I'd be happy to grant commit access.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Jun 25, 2014 at 1:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com> writes:

On Wed, Jun 25, 2014 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org> writes:

Will there be a pg_filedump for 9.4? I'd like to finish package tests
before we release 9.4.0.

Probably, but I have no time for it right now.
FWIW, I believe the current "9.3" sources still work with HEAD/9.4.

I'll check it and post the results.

I forgot to mention that thanks to Christoph Berg, the pg_filedump sources
have gotten off pgfoundry and onto git.postgresql.org. If anyone's got
bandwidth for working on it (in particular, merging the checksum-testing
code that was posted awhile back), I'd be happy to grant commit access.

Merged...

I'm thinking in run "pgindent" to better organize the source code... What
do you think?

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com> writes:

I'm thinking in run "pgindent" to better organize the source code... What
do you think?

Would like that, but I'm not sure what pgindent will do with the //
comments. It's been on my to-do list to switch all the comments to C89
style and then pgindent it, but I don't see myself getting to that in this
decade :-(

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Jun 25, 2014 at 3:52 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Would like that, but I'm not sure what pgindent will do with the //
comments. It's been on my to-do list to switch all the comments to C89
style and then pgindent it, but I don't see myself getting to that in this
decade :-(

I changed all // comments to /* */ and run pgindent.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

Re: Fabr�zio de Royes Mello 2014-06-25 <CAFcNs+oAb8h-0w2vLEWj6R-Gv=xizgdBya3K=SCd_9Tjyo=Zmw@mail.gmail.com>

On Wed, Jun 25, 2014 at 3:52 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Would like that, but I'm not sure what pgindent will do with the //
comments. It's been on my to-do list to switch all the comments to C89
style and then pgindent it, but I don't see myself getting to that in this
decade :-(

I changed all // comments to /* */ and run pgindent.

I've pushed these patches to the git repository, thanks.

Christoph
--
cb@df7cb.de | http://www.df7cb.de/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Em domingo, 31 de agosto de 2014, Christoph Berg <cb@df7cb.de> escreveu:

Re: Fabrízio de Royes Mello 2014-06-25
<CAFcNs+oAb8h-0w2vLEWj6R-Gv=xizgdBya3K=SCd_9Tjyo=Zmw@mail.gmail.com
<javascript:;>>

On Wed, Jun 25, 2014 at 3:52 PM, Tom Lane <tgl@sss.pgh.pa.us

<javascript:;>> wrote:

Would like that, but I'm not sure what pgindent will do with the //
comments. It's been on my to-do list to switch all the comments to C89
style and then pgindent it, but I don't see myself getting to that in

this

decade :-(

I changed all // comments to /* */ and run pgindent.

I've pushed these patches to the git repository, thanks.

Thanks!

Fabrízio de Royes Mello

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

Hi community,
while I am currently investigating why a certain table with highly redundant and utterly verbose xml becomes worse storage wise when making the xml more compact. Since i am quite new to this, I believe its the lz compression in the text database. But thats irrelevant now, just mentioning because tools like pg_filedump allow people like me to help themselves and a basic understanding of things.

During checking I noticed pg_filedump (current from git.postgresql.org incl. the below mentioned commit) does not compile on Mac-OSX. Afaik it will not compile as soon as post.h comes into play and USE_REPL_SNPRINTF is defined. Then printf and sprintf (ouch particular but code path seems tolerable) in the source of pg_filedump become pg_printf and so on. These replacements are part of postgres and can’t be linked into the standalone pg_filedump. At least that is certainly not the intention.

Putting

#undef sprintf
#undef print

after the includes in pg_filedump fixes the mac compile and imho all builds where the USE_REPL_SNPRINTF is defined as a side effect of include postgres.h effectively taking printf from me.

Not sure how to deal with this issue correctly so this is just for your consideration since the issue is a bit broader imho.

Regards,
Stepan

Am 31.08.2014 um 17:25 schrieb Fabrízio de Royes Mello <fabriziomello@gmail.com>: