json_build* volatility error

Started by Andrew Dunstanover 11 years ago4 messages
#1Andrew Dunstan
andrew@dunslane.net

I have just noticed that I inadvertently marked the json_build*
functions as immutable. That seems to be a plain error, as, for example,
timestamptz output will not be immutable. I think we need to fix this
for 9.4. It will mean a catalog bump :-(

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#1)
Re: json_build* volatility error

Andrew Dunstan <andrew@dunslane.net> writes:

I have just noticed that I inadvertently marked the json_build*
functions as immutable. That seems to be a plain error, as, for example,
timestamptz output will not be immutable.

Ah, yes, our convention is that anything depending on datatype I/O
functions is to be marked stable.

I think we need to fix this
for 9.4. It will mean a catalog bump :-(

Agreed.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#2)
Re: json_build* volatility error

On 07/15/2014 11:14 AM, Tom Lane wrote:

I think we need to fix this
for 9.4. It will mean a catalog bump :-(

Agreed.

Are we trying to store these up or just applying them as they go?

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#3)
Re: json_build* volatility error

Andrew Dunstan <andrew@dunslane.net> writes:

Are we trying to store these up or just applying them as they go?

No, just do it.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers