Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical

Started by Michael Paquierover 11 years ago3 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi,

I noticed that pg_receivexlog is able to use --slot but not -S, even
if the code is written this way. Attached is a patch correcting that.
This makes pg_receivexlog consistent with pg_recvlogical regarding the
slot option.
IMHO, this should be backpatched to REL9_4_STABLE.
Regards,
--
Michael

Attachments:

20140812_pg_receivexlog_slot_option.patchtext/x-patch; charset=US-ASCII; name=20140812_pg_receivexlog_slot_option.patchDownload+3-2
#2Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#1)
Re: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical

On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Hi,

I noticed that pg_receivexlog is able to use --slot but not -S, even
if the code is written this way. Attached is a patch correcting that.
This makes pg_receivexlog consistent with pg_recvlogical regarding the
slot option.
IMHO, this should be backpatched to REL9_4_STABLE.
Regards,

Looks good to me. And, I could not find the reason why only -S was not
added, in the past discussion.

Anyway, barring any objection, I will commit this.

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Fujii Masao (#2)
Re: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical

On Tue, Aug 12, 2014 at 7:27 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Hi,

I noticed that pg_receivexlog is able to use --slot but not -S, even
if the code is written this way. Attached is a patch correcting that.
This makes pg_receivexlog consistent with pg_recvlogical regarding the
slot option.
IMHO, this should be backpatched to REL9_4_STABLE.
Regards,

Looks good to me. And, I could not find the reason why only -S was not
added, in the past discussion.

Anyway, barring any objection, I will commit this.

Applied. Thanks!

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers