Typos in comments

Started by Etsuro Fujitaover 11 years ago3 messageshackers
Jump to latest
#1Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp

I ran into a type " a a " in a comment in snapmgr.c, and found that
there are four other places that've made the same typo, by the grep
command. And in one of those places, I found yet another typo. Please
find attached a patch.

Thanks,

Best regards,
Etsuro Fujita

Attachments:

comment-typo-fixes.patchtext/x-patch; name=comment-typo-fixes.patchDownload+6-6
#2David Rowley
dgrowleyml@gmail.com
In reply to: Etsuro Fujita (#1)
Re: Typos in comments

On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
wrote:

I ran into a type " a a " in a comment in snapmgr.c, and found that
there are four other places that've made the same typo, by the grep
command. And in one of those places, I found yet another typo. Please
find attached a patch.

Just while on this topic, I had a quick look at the results from the regex
\b(\w+)\s+\1\b which finds duplicate words. After sifting through the false
positives I found a few more. Patch attached.

Regards

David Rowley

Attachments:

duplicate_word_fix.difftext/plain; charset=US-ASCII; name=duplicate_word_fix.diffDownload+3-3
#3Robert Haas
robertmhaas@gmail.com
In reply to: David Rowley (#2)
Re: Typos in comments

On Mon, Oct 20, 2014 at 3:04 AM, David Rowley <dgrowleyml@gmail.com> wrote:

On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
wrote:

I ran into a type " a a " in a comment in snapmgr.c, and found that
there are four other places that've made the same typo, by the grep
command. And in one of those places, I found yet another typo. Please
find attached a patch.

Just while on this topic, I had a quick look at the results from the regex
\b(\w+)\s+\1\b which finds duplicate words. After sifting through the false
positives I found a few more. Patch attached.

Thanks. I have committed both patches.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers