expected/sequence_1.out obsolete?

Peter Eisentraut <peter_e@gmx.net> writes:

expected/sequence_1.out hasn't been updated at least since
commit d90ced8bb22194cbb45f58beb0961251103aeff5
Date: Thu Oct 3 16:17:18 2013 -0400
and nobody appears to have complained.

Can it be removed?

No, it needs to be fixed. The alternate output from "select * from
foo_seq" will appear occasionally (from memory, if a checkpoint starts
or perhaps completes during the test).

We might have noticed this already if the buildfarm weren't so noisy
lately :-(

An alternative answer would be to remove log_cnt from the set of
columns displayed, but I think that would be taking away part of the
point of that particular test.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Oct 22, 2014 at 4:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

expected/sequence_1.out hasn't been updated at least since

commit d90ced8bb22194cbb45f58beb0961251103aeff5
Date: Thu Oct 3 16:17:18 2013 -0400

and nobody appears to have complained.

Can it be removed?

I don't think that this is a good idea, have a look at bb3f839 explaining
that this alternate output may happen when a checkpoint kicks in. Simple
patch is attached.
--
Michael

Michael Paquier <michael.paquier@gmail.com> writes:

I don't think that this is a good idea, have a look at bb3f839 explaining
that this alternate output may happen when a checkpoint kicks in. Simple
patch is attached.

Pushed, thanks. (The 9.4 branch was broken too, but differently :-()

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers