pgsql: Support frontend-backend protocol communication using a shm_mq.

Started by Robert Haasover 11 years ago5 messageshackers
Jump to latest
#1Robert Haas
robertmhaas@gmail.com

Support frontend-backend protocol communication using a shm_mq.

A background worker can use pq_redirect_to_shm_mq() to direct protocol
that would normally be sent to the frontend to a shm_mq so that another
process may read them.

The receiving process may use pq_parse_errornotice() to parse an
ErrorResponse or NoticeResponse from the background worker and, if
it wishes, ThrowErrorData() to propagate the error (with or without
further modification).

Patch by me. Review by Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2bd9e412f92bc6a68f3e8bcb18e04955cc35001d

Modified Files
--------------
src/backend/libpq/Makefile | 2 +-
src/backend/libpq/pqcomm.c | 98 ++++++++------
src/backend/libpq/pqmq.c | 261 ++++++++++++++++++++++++++++++++++++++
src/backend/utils/adt/numutils.c | 2 +-
src/backend/utils/error/elog.c | 51 ++++++++
src/include/libpq/libpq.h | 36 ++++--
src/include/libpq/pqmq.h | 22 ++++
src/include/utils/builtins.h | 2 +-
src/include/utils/elog.h | 1 +
9 files changed, 428 insertions(+), 47 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Robert Haas (#1)
Re: pgsql: Support frontend-backend protocol communication using a shm_mq.

On 10/31/14 12:47 PM, Robert Haas wrote:

Support frontend-backend protocol communication using a shm_mq.

This fails cpluspluscheck.

src/include/libpq/pqmq.h needs to include something that defines StringInfo.

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Robert Haas
robertmhaas@gmail.com
In reply to: Peter Eisentraut (#2)
Re: pgsql: Support frontend-backend protocol communication using a shm_mq.

On Sat, Nov 1, 2014 at 9:30 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

On 10/31/14 12:47 PM, Robert Haas wrote:

Support frontend-backend protocol communication using a shm_mq.

This fails cpluspluscheck.

src/include/libpq/pqmq.h needs to include something that defines StringInfo.

OK, fixed.

On my MacBook Pro, cpluspluscheck is all but useless, because it gives
a zillion warnings like this:

In file included from src/include/postgres.h:47,
from /tmp/cpluspluscheck.ZkYfcq/test.cpp:2:
src/include/c.h:110:21: error: libintl.h: No such file or directory

I bet that's because I configure --with-libraries=/opt/local/lib
--with-includes=/opt/local/include

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#4Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Robert Haas (#1)
Re: [COMMITTERS] pgsql: Support frontend-backend protocol communication using a shm_mq.

Robert Haas wrote:

Support frontend-backend protocol communication using a shm_mq.

I just noticed that this patch broke the case where a standalone backend
is sent a query that throws an error -- instead, we get a segmentation
fault. Example:

echo "foobar" | postgres --single
PostgreSQL stand-alone backend 9.5devel
backend> Segmentation fault

I guess we could have a src/test/modules subdir that tests simple stuff
on standalone backends ...

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Robert Haas
robertmhaas@gmail.com
In reply to: Alvaro Herrera (#4)
Re: [COMMITTERS] pgsql: Support frontend-backend protocol communication using a shm_mq.

On Thu, Dec 4, 2014 at 4:15 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

Robert Haas wrote:

Support frontend-backend protocol communication using a shm_mq.

I just noticed that this patch broke the case where a standalone backend
is sent a query that throws an error -- instead, we get a segmentation
fault.

Ugh, sorry. Fixed.

Example:

echo "foobar" | postgres --single
PostgreSQL stand-alone backend 9.5devel
backend> Segmentation fault

I guess we could have a src/test/modules subdir that tests simple stuff
on standalone backends ...

Wouldn't hurt. Although it's not something that's likely to get
broken very often.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers