Nitpicky doc corrections for BRIN functions of pageinspect

Started by Michael Paquierover 11 years ago4 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

Just a small thing I noticed while looking at pageinspect.sgml, the
set of SQL examples related to BRIN indexes uses lower-case characters
for reserved keywords. This has been introduced by 7516f52.
Patch is attached.
Regards,
--
Michael

Attachments:

20141120_pageinspect_brin_case.patchapplication/x-patch; name=20141120_pageinspect_brin_case.patchDownload+6-6
In reply to: Michael Paquier (#1)
Re: Nitpicky doc corrections for BRIN functions of pageinspect

On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Just a small thing I noticed while looking at pageinspect.sgml, the
set of SQL examples related to BRIN indexes uses lower-case characters
for reserved keywords. This has been introduced by 7516f52.
Patch is attached.

My nitpicky observation about pageinspect + BRIN was that the comments
added to the pageinspect SQL file for the SQL-callable function
brin_revmap_data() have a comment header style slightly inconsistent
with the existing items.

--
Peter Geoghegan

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Peter Geoghegan (#2)
Re: Nitpicky doc corrections for BRIN functions of pageinspect

Peter Geoghegan wrote:

On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Just a small thing I noticed while looking at pageinspect.sgml, the
set of SQL examples related to BRIN indexes uses lower-case characters
for reserved keywords. This has been introduced by 7516f52.
Patch is attached.

My nitpicky observation about pageinspect + BRIN was that the comments
added to the pageinspect SQL file for the SQL-callable function
brin_revmap_data() have a comment header style slightly inconsistent
with the existing items.

Pushed.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Michael Paquier
michael@paquier.xyz
In reply to: Alvaro Herrera (#3)
Re: Nitpicky doc corrections for BRIN functions of pageinspect

On Wed, Dec 3, 2014 at 12:23 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Peter Geoghegan wrote:

On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Just a small thing I noticed while looking at pageinspect.sgml, the
set of SQL examples related to BRIN indexes uses lower-case characters
for reserved keywords. This has been introduced by 7516f52.
Patch is attached.

My nitpicky observation about pageinspect + BRIN was that the comments
added to the pageinspect SQL file for the SQL-callable function
brin_revmap_data() have a comment header style slightly inconsistent
with the existing items.

Pushed.

Thanks.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers