WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark@port25.com> wrote:

At line 1787 of outfuncs.c, the line:

WRITE_UINT_FIELD(reltablespace)

should probably say

WRITE_OID_FIELD(reltablespace)

since that variable is of type Oid, not uint32.
Granted, these two macros are interchangeable,
but they won't be if we ever move to 64-bit Oids.

For correctness you are right. Looks like you spent quite some time looking
at that..
--
Michael

On 12/11/2014 05:57 AM, Michael Paquier wrote:

On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark@port25.com> wrote:

At line 1787 of outfuncs.c, the line:

WRITE_UINT_FIELD(reltablespace)

should probably say

WRITE_OID_FIELD(reltablespace)

since that variable is of type Oid, not uint32.
Granted, these two macros are interchangeable,
but they won't be if we ever move to 64-bit Oids.

For correctness you are right. Looks like you spent quite some time looking
at that..

Fixed, thanks.

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers