Better error message on pg_upgrade checksum mismatches

Started by Greg Sabino Mullaneabout 11 years ago3 messageshackers
Jump to latest
#1Greg Sabino Mullane
greg@turnstep.com

Just a little thing that's been bugging me. If one side of the
pg_upgrade has checksums and the other does not, give a less
cryptic error message.

--
Greg Sabino Mullane greg@endpoint.com
End Point Corporation
PGP Key: 0x14964AC8

Attachments:

pg_controldata.checksums.better.message.patchtext/x-diff; charset=us-asciiDownload+9-1
#2Bruce Momjian
bruce@momjian.us
In reply to: Greg Sabino Mullane (#1)
Re: Better error message on pg_upgrade checksum mismatches

On Tue, Feb 10, 2015 at 10:55:07AM -0500, Greg Sabino Mullane wrote:

Just a little thing that's been bugging me. If one side of the
pg_upgrade has checksums and the other does not, give a less
cryptic error message.

OK, sure. Good fix, will apply. This seems to be the day for pg_upgrade
fixes/improvements. :-)

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Bruce Momjian
bruce@momjian.us
In reply to: Greg Sabino Mullane (#1)
Re: Better error message on pg_upgrade checksum mismatches

On Tue, Feb 10, 2015 at 10:55:07AM -0500, Greg Sabino Mullane wrote:

Just a little thing that's been bugging me. If one side of the
pg_upgrade has checksums and the other does not, give a less
cryptic error message.

Thanks. Slightly adjusted patch attached and applied to head.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachments:

checksum.difftext/x-diff; charset=us-asciiDownload+12-12