Dereferenced pointer checks in data.c of ECPG

Started by Michael Paquierabout 11 years ago2 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

ecpg_get_data@data.c is using to null-pointer checks for pval but it
happens that we have the guarantee that those pointers are never NULL, see
for example this piece of code at the code of ecpg_get_data():
/* pval is a pointer to the value */
if (!pval)
{
/*
* This should never happen because we already checked that
we found
* at least one tuple, but let's play it safe.
*/
ecpg_raise(lineno, ECPG_NOT_FOUND, ECPG_SQLSTATE_NO_DATA,
NULL);
return (false);
}
A patch is attached, and the issue has been spotted by Coverity.
Regards,
--
Michael

Attachments:

20150225_ecpg_get_data_null_ptrs.patchtext/x-patch; charset=US-ASCII; name=20150225_ecpg_get_data_null_ptrs.patchDownload+3-3
#2Michael Meskes
meskes@postgresql.org
In reply to: Michael Paquier (#1)
Re: Dereferenced pointer checks in data.c of ECPG

A patch is attached, and the issue has been spotted by Coverity.
Regards,

Thanks, committed.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! For�a Bar�a! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers