pgsql: btree_gin: properly call DirectFunctionCall1()
btree_gin: properly call DirectFunctionCall1()
Previously we called DirectFunctionCall3() with dummy arguments.
Patch by Jon Nelson
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/843cd0bfe6246d94d9b34a7f36bbb76fdba87b74
Modified Files
--------------
contrib/btree_gin/btree_gin.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Bruce Momjian <bruce@momjian.us> writes:
btree_gin: properly call DirectFunctionCall1()
Previously we called DirectFunctionCall3() with dummy arguments.
This patch is entirely wrong and has broken the buildfarm.
Please revert.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Tue, Mar 24, 2015 at 10:02:03PM -0400, Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
btree_gin: properly call DirectFunctionCall1()
Previously we called DirectFunctionCall3() with dummy arguments.This patch is entirely wrong and has broken the buildfarm.
Please revert.
OK, done.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Tue, Mar 24, 2015 at 10:35:10PM -0400, Bruce Momjian wrote:
On Tue, Mar 24, 2015 at 10:02:03PM -0400, Tom Lane wrote:
Bruce Momjian <bruce@momjian.us> writes:
btree_gin: properly call DirectFunctionCall1()
Previously we called DirectFunctionCall3() with dummy arguments.This patch is entirely wrong and has broken the buildfarm.
Please revert.OK, done.
OK, I figured out that I was only supposed to change inet_in, not the
other calls to DirectFunctionCall3 (varbit_in and bit_in). Patch
attached.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachments:
btree_gin.difftext/x-diff; charset=us-asciiDownload+5-5
Bruce Momjian <bruce@momjian.us> writes:
OK, I figured out that I was only supposed to change inet_in, not the
other calls to DirectFunctionCall3 (varbit_in and bit_in). Patch
attached.
That looks better ...
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers