Bringing text abbreviation debug output under the control of trace_sort

Started by Peter Geogheganabout 11 years ago3 messageshackers
Jump to latest

Attached patch makes trace_sort control abbreviation debug output for
the text opclass, which makes it consistent with the numeric opclass.
This seems better than relying on someone going to the trouble of
building Postgres themselves to debug cases where abbreviation is the
wrong thing, which we're not 100% sure will not occur. It also allows
wider analysis of where abbreviation helps the most and the least in
production, which is surely a good thing.

I have added this to the next commitfest, but I suggest that it be
quickly committed to the master branch as a maintenance commit.
--
Peter Geoghegan

Attachments:

trace-sort-text.patchtext/x-patch; charset=US-ASCII; name=trace-sort-text.patchDownload+9-10
#2Robert Haas
robertmhaas@gmail.com
In reply to: Peter Geoghegan (#1)
Re: Bringing text abbreviation debug output under the control of trace_sort

On Sun, Apr 5, 2015 at 3:59 PM, Peter Geoghegan <pg@heroku.com> wrote:

Attached patch makes trace_sort control abbreviation debug output for
the text opclass, which makes it consistent with the numeric opclass.
This seems better than relying on someone going to the trouble of
building Postgres themselves to debug cases where abbreviation is the
wrong thing, which we're not 100% sure will not occur. It also allows
wider analysis of where abbreviation helps the most and the least in
production, which is surely a good thing.

I have added this to the next commitfest, but I suggest that it be
quickly committed to the master branch as a maintenance commit.

Done.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

In reply to: Robert Haas (#2)
Re: Bringing text abbreviation debug output under the control of trace_sort

On Tue, Apr 7, 2015 at 7:46 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Done.

Thank you.

--
Peter Geoghegan

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers