fmgr.h

Started by Andrew Dunstanover 10 years ago2 messages
#1Andrew Dunstan
andrew@dunslane.net

... has this comment (fmgr.h:506):

/* These are for invocation of a function identified by OID with a
* directly-computed parameter list. Note that neither arguments
nor result
* are allowed to be NULL. These are essentially FunctionLookup()
followed
* by FunctionCallN(). If the same function is to be invoked
repeatedly,
* do the FunctionLookup() once and then use FunctionCallN().
*/

However, there doesn't appear to be any such animal as FunctionLookup().
Shouldn't it say fmgr_info() instead?

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#1)
Re: fmgr.h

Andrew Dunstan <andrew@dunslane.net> writes:

However, there doesn't appear to be any such animal as FunctionLookup().
Shouldn't it say fmgr_info() instead?

Hmmm ... I think there may have been at the time the comment was written,
but yeah, please change that.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers