Several memory leaks for pg_rewind caused by missing PQclear calls

Started by Michael Paquierover 10 years ago3 messageshackers

michael@paquier.xyz

over 10 years ago

Hi all,

After a run of valgrind on pg_rewind, I found a couple of code paths
missing some PQclear calls after running a query. Attached is a patch
to fix all those leaks.
Regards,
--
Michael

Heikki Linnakangas

heikki.linnakangas@enterprisedb.com

over 10 years ago

In reply to: Michael Paquier (#1)

Re: Several memory leaks for pg_rewind caused by missing PQclear calls

On 07/23/2015 05:08 PM, Michael Paquier wrote:

Hi all,

After a run of valgrind on pg_rewind, I found a couple of code paths
missing some PQclear calls after running a query. Attached is a patch
to fix all those leaks.

Fixed, thanks.

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Michael Paquier

michael@paquier.xyz

over 10 years ago

In reply to: Heikki Linnakangas (#2)

Re: Several memory leaks for pg_rewind caused by missing PQclear calls

On Tue, Jul 28, 2015 at 2:45 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

On 07/23/2015 05:08 PM, Michael Paquier wrote:

Hi all,

After a run of valgrind on pg_rewind, I found a couple of code paths
missing some PQclear calls after running a query. Attached is a patch
to fix all those leaks.

Fixed, thanks.

Thanks for taking care of this.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Several memory leaks for pg_rewind caused by missing PQclear calls

Attachments: