pg_filedump patch for 9.5

Started by Satoshi Nagayasuover 10 years ago4 messageshackers
Jump to latest
#1Satoshi Nagayasu
snaga@uptime.jp

Hi,

I have created a patch for pg_filedump to work with 9.5.
Here is a list of changes.

* Fix to rename CRC32 macros to work with 9.5.
* Fix to add missing DBState: DB_SHUTDOWNED_IN_RECOVERY.
* Fix to add missing page flags for Btree and GIN.
* Update copyright date.

Please take a look. Any comments are welcome.

Regards,

--
NAGAYASU Satoshi <snaga@uptime.jp>

Attachments:

pg_filedump-9.5.difftext/plain; charset=UTF-8; name=pg_filedump-9.5.diffDownload+21-12
#2Pavel Raiskup
praiskup@redhat.com
In reply to: Satoshi Nagayasu (#1)
Re: pg_filedump patch for 9.5

On Saturday 08 of August 2015 20:38:38 Satoshi Nagayasu wrote:

I have created a patch for pg_filedump to work with 9.5.
Here is a list of changes.

* Fix to rename CRC32 macros to work with 9.5.
* Fix to add missing DBState: DB_SHUTDOWNED_IN_RECOVERY.
* Fix to add missing page flags for Btree and GIN.
* Update copyright date.

Please take a look. Any comments are welcome.

Thanks for the patch; it helps with building against 9.5.

Hints I can give ATM:

* copyright is outdated now
* to allow the build with 'make
PGSQL_INCLUDE_DIR=/usr/include/pgsql/server' the following patch is
needed:

    --- a/Makefile
    +++ b/Makefile
    @@ -18,7 +18,7 @@ DISTFILES= README.pg_filedump Makefile Makefile.contrib \
     all: pg_filedump
     pg_filedump: pg_filedump.o
    -       ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o
    +       ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o -lpgport

Pavel

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Christoph Berg
myon@debian.org
In reply to: Pavel Raiskup (#2)
Re: pg_filedump patch for 9.5

Re: Pavel Raiskup 2016-02-26 <8883822.6jZMTTXa3b@nb.usersys.redhat.com>

On Saturday 08 of August 2015 20:38:38 Satoshi Nagayasu wrote:

I have created a patch for pg_filedump to work with 9.5.
Here is a list of changes.

* Fix to rename CRC32 macros to work with 9.5.
* Fix to add missing DBState: DB_SHUTDOWNED_IN_RECOVERY.
* Fix to add missing page flags for Btree and GIN.
* Update copyright date.

Please take a look. Any comments are welcome.

Thanks for the patch; it helps with building against 9.5.

Hints I can give ATM:

* copyright is outdated now
* to allow the build with 'make
PGSQL_INCLUDE_DIR=/usr/include/pgsql/server' the following patch is
needed:

--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@ DISTFILES= README.pg_filedump Makefile Makefile.contrib \
all: pg_filedump
pg_filedump: pg_filedump.o
-       ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o
+       ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o -lpgport

Pavel

Hi,

thanks for the patches, I've pushed them to the git repo.

http://git.postgresql.org/gitweb/?p=pg_filedump.git

Christoph

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Christoph Berg
myon@debian.org
In reply to: Christoph Berg (#3)
pg_filedump 9.5.0

Re: To Pavel Raiskup 2016-03-19 <20160319170614.GB8052@msg.df7cb.de>

thanks for the patches, I've pushed them to the git repo.

http://git.postgresql.org/gitweb/?p=pg_filedump.git

We don't have any place to put releases, so I'm posting the tar ball
here...

Christoph

Attachments:

pg_filedump-9.5.0.tar.gzapplication/gzipDownload